Rename namespace by AlexandraRoatis · Pull Request #1917 · google/knative-gcp

AlexandraRoatis · 2020-11-13T15:05:04Z

Moving to a brand-agnostic namespace.

Proposed Changes

Replace cloud-run-events namespace and prefix with events-system.

Release Note

Replace `cloud-run-events` namespace and prefix with `events-system`.

AlexandraRoatis · 2020-11-13T17:47:59Z

Note: the failing tests are expected to fail due to this change.

AlexandraRoatis · 2020-12-04T14:50:50Z

I'm not sure what to do about these regex:

knative-gcp/config/monitoring/metrics/prometheus/prometheus-scrape-kn-gcp.yaml

Line 13 in 1970c13

regex: cloud-run-events;cloud-run-events;controller;metrics
knative-gcp/config/monitoring/metrics/prometheus/prometheus-scrape-kn-gcp.yaml

Line 29 in 1970c13

regex: cloud-run-events;cloud-run-events;webhook;metrics

AlexandraRoatis · 2020-12-07T21:20:46Z

I think the lint check is incorrect. It identifies a part of the word instead of the entire word.

AlexandraRoatis · 2020-12-10T16:32:34Z

/retest

nlopezgi · 2021-01-07T16:01:27Z

/lgtm
/approve

AlexandraRoatis · 2021-01-07T18:00:53Z

/hold waiting for a review from @Harwayne

Harwayne · 2021-01-07T20:56:46Z

-        namespace: cloud-run-events
-    failurePolicy: Fail
+        namespace: events-system
+    failurePolicy: Ignore


Is this intended to be in this PR? I actually like the change, but am not sure we want to include it in this large renaming PR.

The reason we have it here is that we couldn't get past the webhook issue when testing without it. I can also move it to a separate PR, if preferable.

Harwayne

/lgtm
/approve
/unhold

knative-prow-robot · 2021-01-07T21:00:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexandraRoatis, Harwayne, nlopezgi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [AlexandraRoatis,Harwayne,nlopezgi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

AlexandraRoatis · 2021-01-07T21:37:54Z

/retest

- cloud-run-events-probe -> events-system-probe - cloud-run-events-example -> events-system-example - cloud-run-events-controller -> events-system-controller - cloud-run-events-broker -> events-system-broker - cloud-run-events-webhook -> events-system-webhook - cloud-run-events-source-observer -> events-system-source-observer - cloud-run-events-pubsub-* -> events-pubsub-* - cloud-run-events-* to events-system-* (non-namespace & not service accounts) - cloud-run-events -> events-system (namespace only) - test-cloud-run-events -> test-events-system

This is done to avoid race conditions where the config maps cannot be created due to this validation policy.

AlexandraRoatis · 2021-01-07T22:12:33Z

Merge seemed to still be blocked so I did a rebase to see if it is finally triggered after. /assign @zhongduo

zhongduo · 2021-01-07T22:14:08Z

/lgtm

AlexandraRoatis · 2021-01-07T22:35:42Z

/retest

knative-prow-robot · 2021-01-07T22:49:12Z

@AlexandraRoatis: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-google-knative-gcp-upgrade-tests	`cbc8531`	link	`/test pull-google-knative-gcp-upgrade-tests`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This reverts commit 2435e8c.

knative-prow-robot added the do-not-merge/work-in-progress label Nov 13, 2020

google-cla Bot added the cla: yes (override cla status due to multiple authors bug) label Nov 13, 2020

knative-prow-robot requested review from liu-cong and zhongduo November 13, 2020 15:05

knative-prow-robot added the size/XL label Nov 13, 2020

AlexandraRoatis force-pushed the ns-rename branch from f8946cf to 977fc4a Compare November 13, 2020 15:20

knative-prow-robot added the needs-rebase label Nov 18, 2020

AlexandraRoatis force-pushed the ns-rename branch from 977fc4a to 1f90308 Compare November 23, 2020 18:41

knative-prow-robot removed the needs-rebase label Nov 23, 2020

AlexandraRoatis force-pushed the ns-rename branch 2 times, most recently from 0771683 to b82fb7d Compare November 27, 2020 15:34

AlexandraRoatis changed the title ~~[WIP] Investigate impact of ns rename~~ Rename namespace Nov 27, 2020

knative-prow-robot removed the do-not-merge/work-in-progress label Nov 27, 2020

AlexandraRoatis force-pushed the ns-rename branch from c978364 to b82fb7d Compare December 2, 2020 15:56

AlexandraRoatis requested review from Harwayne, grantr and nlopezgi December 2, 2020 15:58

MohamedElhawaty reviewed Dec 2, 2020

View reviewed changes

Comment thread pkg/apis/configs/brokerdelivery/br_delivery_defaults_test.go Outdated

AlexandraRoatis force-pushed the ns-rename branch from b82fb7d to 5ca6262 Compare December 2, 2020 18:26

knative-prow-robot added the approved label Dec 4, 2020

AlexandraRoatis mentioned this pull request Dec 4, 2020

Rename cloud-run-events to events-system in release 0.19 #1977

Merged

knative-prow-robot added the needs-rebase label Dec 6, 2020

AlexandraRoatis force-pushed the ns-rename branch from 86df846 to 8c2c32c Compare December 7, 2020 21:10

knative-prow-robot removed the needs-rebase label Dec 7, 2020

AlexandraRoatis force-pushed the ns-rename branch from 8c2c32c to 1609e4e Compare December 10, 2020 15:26

AlexandraRoatis mentioned this pull request Dec 14, 2020

Avoid overwriting eventing clusterrole #1993

Merged

knative-prow-robot added the needs-rebase label Jan 7, 2021

AlexandraRoatis force-pushed the ns-rename branch from df2aa53 to 96094b4 Compare January 7, 2021 14:42

knative-prow-robot removed the needs-rebase label Jan 7, 2021

AlexandraRoatis force-pushed the ns-rename branch from 96094b4 to 03ee635 Compare January 7, 2021 15:06

knative-prow-robot assigned nlopezgi Jan 7, 2021

knative-prow-robot added the lgtm label Jan 7, 2021

AlexandraRoatis mentioned this pull request Jan 7, 2021

Require upgrade tests after the namespace change is in a release #2047

Closed

knative-prow-robot added the do-not-merge/hold label Jan 7, 2021

Harwayne reviewed Jan 7, 2021

View reviewed changes

knative-prow-robot removed the do-not-merge/hold label Jan 7, 2021

knative-prow-robot assigned Harwayne Jan 7, 2021

AlexandraRoatis added 2 commits January 7, 2021 17:09

Update the config-validation.yaml to ignore failures

cbc8531

This is done to avoid race conditions where the config maps cannot be created due to this validation policy.

AlexandraRoatis force-pushed the ns-rename branch from 03ee635 to cbc8531 Compare January 7, 2021 22:10

knative-prow-robot removed the lgtm label Jan 7, 2021

knative-prow-robot assigned zhongduo Jan 7, 2021

knative-prow-robot added the lgtm label Jan 7, 2021

knative-prow-robot merged commit 2435e8c into google:master Jan 7, 2021

zhongduo pushed a commit to zhongduo/knative-gcp that referenced this pull request Jan 8, 2021

Revert "Rename namespace (google#1917)"

3b069fc

This reverts commit 2435e8c.

zhongduo pushed a commit to zhongduo/knative-gcp that referenced this pull request Jan 11, 2021

Revert "Rename namespace (google#1917)"

34f4341

This reverts commit 2435e8c.

AlexandraRoatis deleted the ns-rename branch February 25, 2021 15:56

Conversation

AlexandraRoatis commented Nov 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Uh oh!

AlexandraRoatis commented Nov 13, 2020

Uh oh!

Uh oh!

AlexandraRoatis commented Dec 4, 2020

Uh oh!

AlexandraRoatis commented Dec 7, 2020

Uh oh!

AlexandraRoatis commented Dec 10, 2020

Uh oh!

nlopezgi commented Jan 7, 2021

Uh oh!

AlexandraRoatis commented Jan 7, 2021

Uh oh!

Harwayne Jan 7, 2021

Choose a reason for hiding this comment

Uh oh!

AlexandraRoatis Jan 7, 2021

Choose a reason for hiding this comment

Uh oh!

Harwayne left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow-robot commented Jan 7, 2021

Uh oh!

AlexandraRoatis commented Jan 7, 2021

Uh oh!

AlexandraRoatis commented Jan 7, 2021

Uh oh!

zhongduo commented Jan 7, 2021

Uh oh!

AlexandraRoatis commented Jan 7, 2021

Uh oh!

knative-prow-robot commented Jan 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

AlexandraRoatis commented Nov 13, 2020 •

edited

Loading