Skip to content
This repository was archived by the owner on Jun 19, 2022. It is now read-only.

Rename cloud-run-events to events-system in release 0.19#1977

Merged
nlopezgi merged 1 commit into
google:release-0.19-nsfrom
AlexandraRoatis:release-0.19-ns
Dec 7, 2020
Merged

Rename cloud-run-events to events-system in release 0.19#1977
nlopezgi merged 1 commit into
google:release-0.19-nsfrom
AlexandraRoatis:release-0.19-ns

Conversation

@AlexandraRoatis
Copy link
Copy Markdown
Contributor

This change is currently applied to release-0.19 for the diff, however the intention is to create a new branch release-0.19-ns that can be used in the upgrade tests for PR #1917 .

Proposed Changes

  • cloud-run-events-probe -> events-system-probe
  • cloud-run-events-example -> events-system-example
  • cloud-run-events-controller -> events-system-controller
  • cloud-run-events-broker -> events-system-broker
  • cloud-run-events-webhook -> events-system-webhook
  • cloud-run-events-source-observer -> events-system-source-observer
  • cloud-run-events-pubsub-* -> events-pubsub-*
  • cloud-run-events-* to events-system-* (non-namespace & not service accounts)
  • cloud-run-events -> events-system (namespace only)
  • test-cloud-run-events -> test-events-system

Release Note


Docs

@google-cla google-cla Bot added the cla: yes (override cla status due to multiple authors bug) label Dec 4, 2020
@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/events/build/controller.go 83.3% 81.8% -1.5
pkg/reconciler/intevents/pullsubscription/keda/controller.go 88.9% 88.5% -0.4
pkg/reconciler/intevents/pullsubscription/static/controller.go 88.5% 88.0% -0.5
pkg/reconciler/intevents/topic/controller.go 85.0% 84.2% -0.8

@zhongduo
Copy link
Copy Markdown
Contributor

zhongduo commented Dec 4, 2020

I don't think we should do it at all, unless we really want this new namespace in release 0.19.

We can always just change the upgrade test so that it temporary pull yaml from somewhere, which can be whichever commit with the new namespace, when merging to master. IMO upgrade test shouldn't be a factor of whether the new namespace should be in 0.19 or not. It is just a ....test.

@AlexandraRoatis
Copy link
Copy Markdown
Contributor Author

@zhongduo Please read the note in the beginning of the PR. This is not intended to be merged with the release, but I cannot create a meaningful diff otherwise.

@AlexandraRoatis
Copy link
Copy Markdown
Contributor Author

Adding a hold to make it clear that this is not intended to be merged.
/hold

@AlexandraRoatis AlexandraRoatis changed the base branch from release-0.19 to release-0.19-ns December 7, 2020 14:37
- cloud-run-events-probe -> events-system-probe
- cloud-run-events-example -> events-system-example
- cloud-run-events-controller -> events-system-controller
- cloud-run-events-broker -> events-system-broker
- cloud-run-events-webhook -> events-system-webhook
- cloud-run-events-source-observer -> events-system-source-observer
- cloud-run-events-pubsub-* -> events-pubsub-*
- cloud-run-events-* to events-system-* (non-namespace & not service accounts)
- cloud-run-events -> events-system (namespace only)
- test-cloud-run-events -> test-events-system
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Dec 7, 2020

@AlexandraRoatis: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-google-knative-gcp-upgrade-tests 6178e7f link /test pull-google-knative-gcp-upgrade-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nlopezgi
Copy link
Copy Markdown
Contributor

nlopezgi commented Dec 7, 2020

/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexandraRoatis, nlopezgi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [AlexandraRoatis,nlopezgi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AlexandraRoatis
Copy link
Copy Markdown
Contributor Author

/unhold

@nlopezgi nlopezgi merged commit 0064be9 into google:release-0.19-ns Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved cla: yes (override cla status due to multiple authors bug) lgtm size/XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants