Rename cloud-run-events to events-system in release 0.19#1977
Conversation
|
The following is the coverage report on the affected files.
|
|
I don't think we should do it at all, unless we really want this new namespace in release 0.19. We can always just change the upgrade test so that it temporary pull yaml from |
|
@zhongduo Please read the note in the beginning of the PR. This is not intended to be merged with the release, but I cannot create a meaningful diff otherwise. |
|
Adding a hold to make it clear that this is not intended to be merged. |
- cloud-run-events-probe -> events-system-probe - cloud-run-events-example -> events-system-example - cloud-run-events-controller -> events-system-controller - cloud-run-events-broker -> events-system-broker - cloud-run-events-webhook -> events-system-webhook - cloud-run-events-source-observer -> events-system-source-observer - cloud-run-events-pubsub-* -> events-pubsub-* - cloud-run-events-* to events-system-* (non-namespace & not service accounts) - cloud-run-events -> events-system (namespace only) - test-cloud-run-events -> test-events-system
5792c72 to
6178e7f
Compare
|
@AlexandraRoatis: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlexandraRoatis, nlopezgi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
This change is currently applied to
release-0.19for the diff, however the intention is to create a new branchrelease-0.19-nsthat can be used in the upgrade tests for PR #1917 .Proposed Changes
Release Note
Docs