Skip to content
This repository was archived by the owner on Jun 19, 2022. It is now read-only.

Add ClusterRole to get, list and watch pullsubscriptions and storages#292

Merged
knative-prow-robot merged 6 commits into
google:masterfrom
capri-xiyue:issue_252
Oct 9, 2019
Merged

Add ClusterRole to get, list and watch pullsubscriptions and storages#292
knative-prow-robot merged 6 commits into
google:masterfrom
capri-xiyue:issue_252

Conversation

@capri-xiyue
Copy link
Copy Markdown
Contributor

@capri-xiyue capri-xiyue commented Sep 19, 2019

Fixes #252

Proposed Changes

  • Add ClusterRole to get, list and watch pullsubscriptions and storages

Release Note

None

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Sep 19, 2019

Hi @capri-xiyue. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Sep 19, 2019

@capri-xiyue: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@n3wscott
Copy link
Copy Markdown
Contributor

n3wscott commented Sep 19, 2019

/ok-to-test
/lgtm
/approve
/hold
hold until knative/eventing#1856 lands

@capri-xiyue capri-xiyue mentioned this pull request Sep 19, 2019
Closed
n3wscott
n3wscott reviewed Sep 19, 2019
View reviewed changes
Comment thread config/201-clusterrole.yaml Outdated
name: knative-gcp-pullsubscription-resolver
labels:
eventing.knative.dev/release: devel
duck.knative.dev/sourceObserver: "true"
Copy link
Copy Markdown
Contributor

@n3wscott n3wscott Sep 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be duck.knative.dev/sourceObserver

@capri-xiyue capri-xiyue mentioned this pull request Oct 9, 2019
Closed
Harwayne
Harwayne reviewed Oct 9, 2019
View reviewed changes
Comment thread config/201-clusterrole.yaml Outdated
Comment thread config/201-clusterrole.yaml Outdated
duck.knative.dev/source: "true"
rules:
- apiGroups:
- "pubsub.cloud.run"
Copy link
Copy Markdown
Contributor

@Harwayne Harwayne Oct 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this changed in #332.

Copy link
Copy Markdown
Contributor Author

@capri-xiyue capri-xiyue Oct 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This clusterrole never gets merged into master branch. Therefore Nacho can't see it and he didn't change it in #332

Comment thread config/201-clusterrole.yaml Outdated
Comment thread config/201-clusterrole.yaml Outdated
duck.knative.dev/source: "true"
rules:
- apiGroups:
- "events.cloud.run"
Copy link
Copy Markdown
Contributor

@Harwayne Harwayne Oct 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this changed in #332.

Copy link
Copy Markdown
Contributor Author

@capri-xiyue capri-xiyue Oct 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This clusterrole never gets merged into master branch. Therefore Nacho can't see it and he didn't change it in #332

grantr
grantr approved these changes Oct 9, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Oct 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: capri-xiyue, grantr, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 790a287 into google:master Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

3 more reviewers

@Harwayne Harwayne Harwayne left review comments

@n3wscott n3wscott n3wscott left review comments

@grantr grantr grantr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@grantr grantr

@n3wscott n3wscott

Labels

approved lgtm ok-to-test size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add ClusterRole to get, list and watch "pullsubscriptions" and "storages"

5 participants

@capri-xiyue @knative-prow-robot @n3wscott @grantr @Harwayne