Skip to content
This repository was archived by the owner on Jun 19, 2022. It is now read-only.

Changing APIGroups#332

Merged
knative-prow-robot merged 1 commit into
google:masterfrom
nachocano:apigroup
Oct 9, 2019
Merged

Changing APIGroups#332
knative-prow-robot merged 1 commit into
google:masterfrom
nachocano:apigroup

Conversation

@nachocano
Copy link
Copy Markdown
Member

@nachocano nachocano commented Oct 9, 2019

Fixes #331

  • Changing APIGroups from x.cloud.run to x.cloud.google.com:
    • events.cloud.google.com (PubSub, Storage, Scheduler)
    • messaging.cloud.google.com (Channel)
    • pubsub.cloud.google.com (Topic and PullSubscription)

/assign @vaikas-google

@nachocano
Copy link
Copy Markdown
Member Author

/hold
until we sync and see if we want to get rid of other "cloud-run" names as well (e.g., in controllers, namespaces, etc., etc.)

@nachocano
Copy link
Copy Markdown
Member Author

nachocano commented Oct 9, 2019

fyi @aaron-lerner
if you clone this fork and ko apply it, you will be able to test the CLI e2e... until it gets merged (hopefully soon)

@nachocano
Copy link
Copy Markdown
Member Author

/hold cancel

it seems that we want to get rid of all "run" names... but that can be done in a separate PR...

@akashrv akashrv added priority/1 Blocks current release defined by release/* label or blocks current milestone release/1 labels Oct 9, 2019
@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Oct 9, 2019

/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nachocano, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved lgtm priority/1 Blocks current release defined by release/* label or blocks current milestone release/1 size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Sources APIGroup

4 participants