Skip to content
This repository was archived by the owner on Jan 10, 2023. It is now read-only.

Conversation

@JeffLIrion
Copy link
Contributor

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@coveralls
Copy link

coveralls commented Aug 23, 2018

Coverage Status

Coverage increased (+1.6%) to 43.893% when pulling a8938ca on JeffLIrion:master into 82bfd52 on google:master.

@JeffLIrion
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@JeffLIrion
Copy link
Contributor Author

Is there anything you need from me for this pull request? I've got a pull request for another Python package (https://github.com/happyleavesaoc/python-firetv) that uses this ADB library and requires these changes for Python 3 compatibility. If you could review this PR and release a new version so that I can update the requirements for firetv, that would be much appreciated!

@chilicheech
Copy link

Any updates on this? This PR is very useful in for me 😄

@JeffLIrion
Copy link
Contributor Author

I would really appreciate it if you could review this PR. I've got some pull requests that I'd like to submit to other packages -- python-firetv and home-assistant -- that are dependent upon the changes contained in this PR.

@tuxuser
Copy link
Contributor

tuxuser commented Oct 3, 2018

@JeffLIrion usually pull requests dont bump the package version, the maintainer decides when to do so. Maybe you could change that and see if the coverall test accepts it. However, it makes no sense to me why a version bump interferes with code coverage...

Additionally, you could write tests -> higher possibility of it getting accepted.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@JeffLIrion JeffLIrion changed the title Python 3 string fixes Python 3 string fixes and additional tests Oct 4, 2018
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@tuxuser
Copy link
Contributor

tuxuser commented Oct 4, 2018

I am very okay with contributing to this project!

@tuxuser
Copy link
Contributor

tuxuser commented Oct 4, 2018

@fahhem Sorry for triggering you, assuming you are quite busy, but it's somewhat urgent. This PR fixes basic py3 compatibility, it would be a great thing to have! Thank you!

@JeffLIrion
Copy link
Contributor Author

I tried to change the email used by @tuxuser in his commits to the email that he used when signing the CLA, but it made a mess of the repository so I reverted to the state before modifying the commit emails. PR #128 is exactly the same, but all the commits are in my name. Sorry for the trouble!

@fahhem
Copy link
Contributor

fahhem commented Oct 4, 2018

Closing in favor of #128

@fahhem fahhem closed this Oct 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants