-
Notifications
You must be signed in to change notification settings - Fork 360
Python 3 string fixes and additional tests #119
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it! |
|
CLAs look good, thanks! |
|
Is there anything you need from me for this pull request? I've got a pull request for another Python package (https://github.com/happyleavesaoc/python-firetv) that uses this ADB library and requires these changes for Python 3 compatibility. If you could review this PR and release a new version so that I can update the requirements for firetv, that would be much appreciated! |
|
Any updates on this? This PR is very useful in for me 😄 |
|
I would really appreciate it if you could review this PR. I've got some pull requests that I'd like to submit to other packages -- python-firetv and home-assistant -- that are dependent upon the changes contained in this PR. |
|
@JeffLIrion usually pull requests dont bump the package version, the maintainer decides when to do so. Maybe you could change that and see if the coverall test accepts it. However, it makes no sense to me why a version bump interferes with code coverage... Additionally, you could write tests -> higher possibility of it getting accepted. |
Add tests, rewrite Tcp/Usb-stubs, add mock-package to tox deps
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
I am very okay with contributing to this project! |
|
@fahhem Sorry for triggering you, assuming you are quite busy, but it's somewhat urgent. This PR fixes basic py3 compatibility, it would be a great thing to have! Thank you! |
|
Closing in favor of #128 |
No description provided.