Skip to content

Enable save button when only one interface is available #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sofyakurilova merged 1 commit into from
Feb 14, 2024
Merged

Enable save button when only one interface is available #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/ui/src/app/components/general-settings/general-settings.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ <h2 class="settings-drawer-header-title">Connection settings</h2>
class="save-button"
color="primary"
(click)="saveSetting()"
[disabled]="!isFormValues || isLessThanTwoInterfaces">
[disabled]="!isFormValues || isLessThanOneInterface">
Save
</button>
</div>
Expand Down
8 changes: 2 additions & 6 deletions modules/ui/src/app/components/general-settings/general-settings.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,13 +249,9 @@ describe('GeneralSettingsComponent', () => {
});
});

describe('with intefaces lenght less then two', () => {
describe('with interfaces length less than one', () => {
beforeEach(() => {
component.interfaces = { mockDeviceValue: 'mockDeviceValue' };
testRunServiceMock.systemConfig$ = of(MOCK_SYSTEM_CONFIG_WITH_DATA);
testRunServiceMock.getSystemConfig.and.returnValue(
of(MOCK_SYSTEM_CONFIG_WITH_DATA)
);
component.interfaces = {};
fixture.detectChanges();
});

Expand Down
4 changes: 2 additions & 2 deletions modules/ui/src/app/components/general-settings/general-settings.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ export class GeneralSettingsComponent implements OnInit, OnDestroy {
return this.settingForm.hasError('hasSameValues');
}

get isLessThanTwoInterfaces(): boolean {
return Object.keys(this.interfaces).length < 2;
get isLessThanOneInterface(): boolean {
return Object.keys(this.interfaces).length < 1;
}

constructor(
Expand Down