Enable save button when only one interface is available #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sofyakurilova
commented
Feb 14, 2024
sofyakurilova
commented
jboddey
approved these changes
Feb 14, 2024
Collaborator
There was a problem hiding this comment.
I compare this PR with the original one that already merged in the dev branch and see some differences. Here the original PR for this bug: https://github.com/google/testrun/pull/252/files
Do we expect it?
sofyakurilova
force-pushed
the
bug/save_button
branch
from
9102636 to
3184340
Compare
OlgaMardvilko
approved these changes
Feb 14, 2024
jboddey
added a commit
that referenced
this pull request
Feb 19, 2024
* Bump fastapi to 0.109.1 * Write container logs to file * Fix tls test module * Pin dependencies * Change error message for testrun already running (#262) * Change error message for testrun already running * Update testing scripts * Bump vite and @angular-devkit/build-angular in /modules/ui (#265) Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) to 4.5.2 and updates ancestor dependency [@angular-devkit/build-angular](https://github.com/angular/angular-cli). These dependencies need to be updated together. Updates `vite` from 4.5.1 to 4.5.2 - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v4.5.2/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v4.5.2/packages/vite) Updates `@angular-devkit/build-angular` from 16.2.11 to 16.2.12 - [Release notes](https://github.com/angular/angular-cli/releases) - [Changelog](https://github.com/angular/angular-cli/blob/main/CHANGELOG.md) - [Commits](angular/angular-cli@16.2.11...16.2.12) --- updated-dependencies: - dependency-name: vite dependency-type: indirect - dependency-name: "@angular-devkit/build-angular" dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update URL used by UI (#266) * formatting/pylint score * Bump version * Allow modification of API URL * Resolve container logs on separate thread to prevent blocking * Add appropriate headings (#258) * TLSv1.3 server bug fix * Enable save button when only one interface is available (#271) * Bump version --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Sofia Kurilova <sonnycactus@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com>
hitnik
pushed a commit
that referenced
this pull request
Jul 22, 2024
* Bump fastapi to 0.109.1 * Write container logs to file * Fix tls test module * Pin dependencies * Change error message for testrun already running (#262) * Change error message for testrun already running * Update testing scripts * Bump vite and @angular-devkit/build-angular in /modules/ui (#265) Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) to 4.5.2 and updates ancestor dependency [@angular-devkit/build-angular](https://github.com/angular/angular-cli). These dependencies need to be updated together. Updates `vite` from 4.5.1 to 4.5.2 - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v4.5.2/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v4.5.2/packages/vite) Updates `@angular-devkit/build-angular` from 16.2.11 to 16.2.12 - [Release notes](https://github.com/angular/angular-cli/releases) - [Changelog](https://github.com/angular/angular-cli/blob/main/CHANGELOG.md) - [Commits](angular/angular-cli@16.2.11...16.2.12) --- updated-dependencies: - dependency-name: vite dependency-type: indirect - dependency-name: "@angular-devkit/build-angular" dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update URL used by UI (#266) * formatting/pylint score * Bump version * Allow modification of API URL * Resolve container logs on separate thread to prevent blocking * Add appropriate headings (#258) * TLSv1.3 server bug fix * Enable save button when only one interface is available (#271) * Bump version --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Sofia Kurilova <sonnycactus@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.