Skip to content

Conversation

@jboddey
Copy link
Contributor

@jboddey jboddey commented Feb 5, 2024

No description provided.

@jboddey jboddey marked this pull request as ready for review February 7, 2024 16:23
@jboddey

This comment was marked as outdated.

@jboddey jboddey self-assigned this Feb 9, 2024
* Change error message for testrun already running

* Update testing scripts
@jboddey jboddey added this to the Release 1.1.2 milestone Feb 12, 2024
sofyakurilova and others added 2 commits February 12, 2024 16:47
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) to 4.5.2 and updates ancestor dependency [@angular-devkit/build-angular](https://github.com/angular/angular-cli). These dependencies need to be updated together.


Updates `vite` from 4.5.1 to 4.5.2
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v4.5.2/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v4.5.2/packages/vite)

Updates `@angular-devkit/build-angular` from 16.2.11 to 16.2.12
- [Release notes](https://github.com/angular/angular-cli/releases)
- [Changelog](https://github.com/angular/angular-cli/blob/main/CHANGELOG.md)
- [Commits](angular/angular-cli@16.2.11...16.2.12)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: indirect
- dependency-name: "@angular-devkit/build-angular"
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@jhughesoti
Copy link
Contributor

Download button does not work with remote connections, still hard coded to localhost. Should be updated to use similar methods implemented a233292

image

@jhughesoti

This comment has been minimized.

@jboddey
Copy link
Contributor Author

jboddey commented Feb 13, 2024

@jhughesbiot Could you try out the changes? I have added api_url to system.json

@jhughesoti
Copy link
Contributor

I have added api_url to system.json

This shouldn't need to be configured, it should auto detect just like the other download link. This is likely a UI update to complete full remote connection feature.

@jhughesoti
Copy link
Contributor

@jboddey I found an issue with the new container logging that was blocking the main run loop for the test container. I moved this to it's own thread and pushed an update to correct. Please confirm this is good on your end before merging.

@jboddey
Copy link
Contributor Author

jboddey commented Feb 14, 2024

I have added api_url to system.json

This shouldn't need to be configured, it should auto detect just like the other download link. This is likely a UI update to complete full remote connection feature.

If we want the remote access in this patch version then this implementation will have to do for now. Otherwise it will have to be delayed until v1.2

2 similar comments
@jboddey
Copy link
Contributor Author

jboddey commented Feb 14, 2024

I have added api_url to system.json

This shouldn't need to be configured, it should auto detect just like the other download link. This is likely a UI update to complete full remote connection feature.

If we want the remote access in this patch version then this implementation will have to do for now. Otherwise it will have to be delayed until v1.2

@jboddey
Copy link
Contributor Author

jboddey commented Feb 14, 2024

I have added api_url to system.json

This shouldn't need to be configured, it should auto detect just like the other download link. This is likely a UI update to complete full remote connection feature.

If we want the remote access in this patch version then this implementation will have to do for now. Otherwise it will have to be delayed until v1.2

@jhughesoti

This comment was marked as resolved.

@jboddey jboddey merged commit 3177827 into main Feb 19, 2024
hitnik pushed a commit that referenced this pull request Jul 22, 2024
* Bump fastapi to 0.109.1

* Write container logs to file

* Fix tls test module

* Pin dependencies

* Change error message for testrun already running (#262)

* Change error message for testrun already running

* Update testing scripts

* Bump vite and @angular-devkit/build-angular in /modules/ui (#265)

Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) to 4.5.2 and updates ancestor dependency [@angular-devkit/build-angular](https://github.com/angular/angular-cli). These dependencies need to be updated together.


Updates `vite` from 4.5.1 to 4.5.2
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v4.5.2/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v4.5.2/packages/vite)

Updates `@angular-devkit/build-angular` from 16.2.11 to 16.2.12
- [Release notes](https://github.com/angular/angular-cli/releases)
- [Changelog](https://github.com/angular/angular-cli/blob/main/CHANGELOG.md)
- [Commits](angular/angular-cli@16.2.11...16.2.12)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: indirect
- dependency-name: "@angular-devkit/build-angular"
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update URL used by UI (#266)

* formatting/pylint score

* Bump version

* Allow modification of API URL

* Resolve container logs on separate thread to prevent blocking

* Add appropriate headings (#258)

* TLSv1.3 server bug fix

* Enable save button when only one interface is available (#271)

* Bump version

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Sofia Kurilova <sonnycactus@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants