Add appropriate headings #258
Conversation
|
Need to disable text overflow in test result descriptions before merging |
|
Changing the the headers to use the h1/2/3 will change the formatting of the module reports from markdown that use these and likely breaking the formatting there. Unclear on the need to change the class vs updating the CSS for this header classes. If this is necessary, the markdown translation formatting will need to be addressed before merging. |
|
We need to change the class so that when it is converted into a PDF, the headers are suitable for screen readers. This is a blocking feature for our accessibility rating. We can deal with any issues in the module reports once release/v1.1.2 is merged into dev. |
|
If this change breaks other elements of the report, we shouldn't approve and merge until the break is addressed within the same PR. No need to knowingly introduce bugs especially into a release branch. |
|
Looking back at this, there is no plan to release the module reports in this release. Module reports will be released end of Q1 whilst we expect to release this end of this month at the latest. When the time comes, and we open the PR to merge release/v1.1.2 into dev (which may reveal these bugs) I will fix any CSS issues. We are still awaiting the actual designs for module report formatting so we would be making extra work for ourselves to fix this now. |
jboddey
force-pushed
the
release/v1.1.2
branch
from
5413e8e to
e94b574
Compare
|
PDF report currently cuts off overflow of test descriptions. This should be updated to text-wrap or shorten test descriptions to improve accessibility. |
* Bump fastapi to 0.109.1 * Write container logs to file * Fix tls test module * Pin dependencies * Change error message for testrun already running (#262) * Change error message for testrun already running * Update testing scripts * Bump vite and @angular-devkit/build-angular in /modules/ui (#265) Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) to 4.5.2 and updates ancestor dependency [@angular-devkit/build-angular](https://github.com/angular/angular-cli). These dependencies need to be updated together. Updates `vite` from 4.5.1 to 4.5.2 - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v4.5.2/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v4.5.2/packages/vite) Updates `@angular-devkit/build-angular` from 16.2.11 to 16.2.12 - [Release notes](https://github.com/angular/angular-cli/releases) - [Changelog](https://github.com/angular/angular-cli/blob/main/CHANGELOG.md) - [Commits](angular/angular-cli@16.2.11...16.2.12) --- updated-dependencies: - dependency-name: vite dependency-type: indirect - dependency-name: "@angular-devkit/build-angular" dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update URL used by UI (#266) * formatting/pylint score * Bump version * Allow modification of API URL * Resolve container logs on separate thread to prevent blocking * Add appropriate headings (#258) * TLSv1.3 server bug fix * Enable save button when only one interface is available (#271) * Bump version --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Sofia Kurilova <sonnycactus@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com>
* Bump fastapi to 0.109.1 * Write container logs to file * Fix tls test module * Pin dependencies * Change error message for testrun already running (#262) * Change error message for testrun already running * Update testing scripts * Bump vite and @angular-devkit/build-angular in /modules/ui (#265) Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) to 4.5.2 and updates ancestor dependency [@angular-devkit/build-angular](https://github.com/angular/angular-cli). These dependencies need to be updated together. Updates `vite` from 4.5.1 to 4.5.2 - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v4.5.2/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v4.5.2/packages/vite) Updates `@angular-devkit/build-angular` from 16.2.11 to 16.2.12 - [Release notes](https://github.com/angular/angular-cli/releases) - [Changelog](https://github.com/angular/angular-cli/blob/main/CHANGELOG.md) - [Commits](angular/angular-cli@16.2.11...16.2.12) --- updated-dependencies: - dependency-name: vite dependency-type: indirect - dependency-name: "@angular-devkit/build-angular" dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update URL used by UI (#266) * formatting/pylint score * Bump version * Allow modification of API URL * Resolve container logs on separate thread to prevent blocking * Add appropriate headings (#258) * TLSv1.3 server bug fix * Enable save button when only one interface is available (#271) * Bump version --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Sofia Kurilova <sonnycactus@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com>
3 participants
No description provided.