-
Notifications
You must be signed in to change notification settings - Fork 15
Add device types and technologies endpoints #658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update NTP report * cleanup imports * pylint updates
* Adds qualification form and creates first step
* Refactoring - create common dynamic form; adds dynamic form in risk profile and device qualification process; generate 2nd step dynamically
* device profile questions endpoint * test "device/format" endpoint * 404 enstead of 400 * step title and description
Contributor
|
Seems like this is pretty out of sync with the expected merge location. Can we get the merge strategy cleaned up for this PR so it can be reviewed properly? |
* Adds validation between steps
* Adds expired device callout * Save state of callout in session storage
Signed-off-by: J Boddey <boddey@google.com>
Signed-off-by: J Boddey <boddey@google.com>
Contributor
Author
This is resolved now. |
Contributor
Author
|
@hitnik could you take a look at this PR? |
jhughesoti
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.