Endpoint for a device profile questions #668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jboddey
reviewed
Aug 8, 2024
Contributor
jboddey
left a comment
jboddey
left a comment
There was a problem hiding this comment.
I'm unsure of the use of an ID in these questions. For single select answers we have previously just used the string
Collaborator
Author
@jboddey I primarily did this for multiselect answer options, but I added IDs to other questions for consistency. |
jboddey
approved these changes
Aug 13, 2024
jboddey
added a commit
that referenced
this pull request
Aug 27, 2024
* Add not started and disabled test results * Small fix * Add new device type & tech endpoints * store in the json file device types with risks, but return only a list of device types * Update NTP report (#666) * Update NTP report * cleanup imports * pylint updates * Adds qualification form and creates first step (#670) * Adds qualification form and creates first step * Select device type (#679) * Refactoring - create common dynamic form; adds dynamic form in risk profile and device qualification process; generate 2nd step dynamically * Endpoint for a device profile questions (#668) * device profile questions endpoint * test "device/format" endpoint * 404 enstead of 400 * step title and description * Remove old endpoint files * Step 3 qualification process (#681) * Adds validation between steps * delete device type and data coollect from risk profile (#685) * Adds summary step; add close form pop-up; save is not in scope (#689) * 356882947: (feat) add pilot program section to welcome modal (#694) * Display outdated device Banner (#693) * Adds expired device callout * Save state of callout in session storage * Save state of callout in session storage (#696) * Fix test_orc path * Fix tests (#708) * Remove duplicate method * Fix testrun refernce --------- Signed-off-by: J Boddey <boddey@google.com> Co-authored-by: Aliaksandr Nikitsin <aliaksandrn@google.com> Co-authored-by: jhughesbiot <jonathan.hughes@buildingsiot.com> Co-authored-by: Sofia Kurilova <kurilova@google.com> Co-authored-by: Olga Mardvilko <mardvilka@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored the code so that a single endpoint will be used for all questions and answers. The questions are divided into steps, and if there is a subsequent step, a link to the next step will be included in the response. Each question and each answer has been assigned an ID. We discussed this solution with the team and concluded that it would be more convenient this way. Of course, at the moment, there is no need for such a structure, but it is implemented with the addition of new questions in mind.