clang-format: fix tests on old vim without textprop#150
Closed
sam-mccall wants to merge 1 commit intogoogle:masterfrom
Closed
clang-format: fix tests on old vim without textprop#150sam-mccall wants to merge 1 commit intogoogle:masterfrom
sam-mccall wants to merge 1 commit intogoogle:masterfrom
Conversation
dbarnett
suggested changes
May 19, 2020
Contributor
dbarnett
left a comment
dbarnett
left a comment
There was a problem hiding this comment.
Thanks, Sam!
One minor suggestion to add a clarifying note.
| | return 1234567890; }<CR> | ||
| :call prop_type_add('keyword', {}) | ||
| :call prop_add(1, 1, {'length': 3, 'type': 'keyword'}) | ||
| :if has('textprop') |
Contributor
There was a problem hiding this comment.
Nit: Add a note to clarify we're not verifying anything interesting in the !has('textprop') case. Something like this:
Suggested change
| :if has('textprop') | |
| This skips the textprop case if not supported (meaning this block won't do any | |
| interesting verification when run in older versions of vim). | |
| :if has('textprop') |
Contributor
|
I can include these fixes in with other test fixes I'm making. Apparently we had a few different unhandled breakages lately. |
Contributor
|
Obsoleted by #159. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
d8dd427 broke the CI: https://travis-ci.org/github/google/vim-codefmt/jobs/680186570.