Skip to content

clang-format: fix tests on old vim without textprop #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sam-mccall wants to merge 1 commit into from
Closed

clang-format: fix tests on old vim without textprop #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions vroom/clangformat.vroom
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,10 @@ like line2byte() and :goto being buggy in that case.
% int f() {<CR>
| int i=1;<CR>
| return 1234567890; }<CR>
:call prop_type_add('keyword', {})
:call prop_add(1, 1, {'length': 3, 'type': 'keyword'})
:if has('textprop')
Copy link
Copy Markdown
Contributor

@dbarnett dbarnett May 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Add a note to clarify we're not verifying anything interesting in the !has('textprop') case. Something like this:

Suggested change
:if has('textprop')
This skips the textprop case if not supported (meaning this block won't do any
interesting verification when run in older versions of vim).
:if has('textprop')

: call prop_type_add('keyword', {})
: call prop_add(1, 1, {'length': 3, 'type': 'keyword'})
:endif
:call cursor(2, 10)
:echomsg getline('.')[col('.')-1]
~ =
Expand Down