-
Notifications
You must be signed in to change notification settings - Fork 104
@AutoValue HttpRequestRunnable #509
@AutoValue HttpRequestRunnable #509
Conversation
|
PTAL |
Codecov Report
@@ Coverage Diff @@
## master #509 +/- ##
============================================
- Coverage 75% 74.88% -0.12%
Complexity 971 971
============================================
Files 183 183
Lines 4236 4216 -20
Branches 335 335
============================================
- Hits 3177 3157 -20
Misses 906 906
Partials 153 153
Continue to review full report at Codecov.
|
924d3eb to
e83bc07
Compare
e83bc07 to
e4377de
Compare
vam-google
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with one comment (please address that or provide additional details explaining why the current implementation is correct).
| .setApiMethodDescriptor(methodDescriptor) | ||
| .setHttpTransport(new MockHttpTransport()) | ||
| .setJsonFactory(new JacksonFactory()) | ||
| .setResponseFuture(SettableApiFuture.<Void>create()) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The response future should not be nullable.
It seems common in google-cloud-java to have a Void type that represents the response type.
|
@andreamlin, is this PR ready to be merged? |
|
@sduskis ack |
Make class
HttpRequestRunnablean AutoValue class for simplicity.