Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

Conversation

@andreamlin
Copy link
Contributor

@andreamlin andreamlin commented Feb 1, 2019

This pull request was generated using releasetool.

02-01-2019 12:02 PST

Implementation Changes

  • Use ManagedChannelBuilder so user creds don't get overwritten (#650)
  • Always add Content-Length header (#648)
  • Use GoogleDefaultChannelBuilder (#627)

Internal / Testing Changes

  • Add another unit test for JSON fieldmask serialization (#654)
  • @AutoValue HttpRequestRunnable (#509)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 1, 2019
@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #655 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #655   +/-   ##
=========================================
  Coverage     75.57%   75.57%           
  Complexity     1008     1008           
=========================================
  Files           187      187           
  Lines          4365     4365           
  Branches        343      343           
=========================================
  Hits           3299     3299           
  Misses          911      911           
  Partials        155      155

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 834cbdf...5371dd9. Read the comment docs.

@andreamlin andreamlin requested a review from chingor13 February 4, 2019 23:25
@andreamlin
Copy link
Contributor Author

PTAL

@andreamlin andreamlin requested review from sduskis and vam-google and removed request for chingor13 February 4, 2019 23:45
@andreamlin andreamlin merged commit 2c837c5 into master Feb 5, 2019
@andreamlin andreamlin deleted the release-gax-java-v1.38.0 branch February 5, 2019 19:42
@andreamlin
Copy link
Contributor Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants