This repository was archived by the owner on Sep 26, 2023. It is now read-only.
Adding gax-bom #607
Merged
Adding gax-bom #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #607 +/- ##
=========================================
Coverage 75.03% 75.03%
Complexity 935 935
=========================================
Files 177 177
Lines 4090 4090
Branches 323 323
=========================================
Hits 3069 3069
Misses 869 869
Partials 152 152Continue to review full report at Codecov.
|
vam-google
approved these changes
Oct 19, 2018
Contributor
vam-google
left a comment
vam-google
left a comment
There was a problem hiding this comment.
LGTM with one comment
| } | ||
|
|
||
| assemble.dependsOn copyPom | ||
|
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This was referenced Oct 19, 2018
Raibaz
pushed a commit
to Raibaz/gax-java
that referenced
this pull request
Oct 25, 2018
Raibaz
pushed a commit
to Raibaz/gax-java
that referenced
this pull request
Oct 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #594
Testing:
./gradlew publishToMavenLocalworks; verified that google-cloud-java can use the locally-installed gax-bom module in place of listing gax dependencies in google-cloud-bom./gradlew publishMavenJavaPublicationToMavenRepositoryworks (checked the artifacts in Sonatype, but dropped the staged artifacts)