-
Notifications
You must be signed in to change notification settings - Fork 4k
Adding Bom #5209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Bom #5209
Conversation
|
can you take a close look at the scope of dependency, and also list of dependencies in BOM? do we want to upgrade gradle 5 and use BOM in /build.gradle? or we remove non io.grpc dependencies from BOM, so we don't need to maintain two versions if we want to keep current version of gradle. |
dapengzhang0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general LGTM. The bom/build.gradle is more complicated than I expected though.
|
Is |
TheIndifferent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not ping transitive dependencies via BOM, that should be done differently.
|
@dapengzhang0, maven-enforcer-plugin is still necessary after this to ensure the BOM is not accidentally downgrading a version, there may be mulitple BOMs, and because all Maven users should really be using requireUpperBoundDeps for their own sanity. |
|
Quite a few major changes are made. PTAL |
…nal dependency order
adapted from gax-java's BOM: googleapis/gax-java#607
some of examples with maven pom is also converted to use bom.
resolves #3954