-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Closed
Labels
priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
APIs that introduce resource name message configurations to their GAPIC yaml will lose the format-* methods that format resource names. So as to not break clients, we have to reintroduce these methods.
APIs affected:
Steps to fix:
- check-in gapic-generator fix to reenable the formatting methods (DONE)~ edit: this turned out to be partially wrong
- releasing artman v0.16.11 to pick up that fix (DONE)
- fix bug introduced by above PR, BoolValue presence checking gapic-generator#2561
- releasing artman v0.16.11 to pick up that fix
- updating the GAPIC config for the affected APIs; this would be done internally and then bubble up to the github googleapis repo
Ideally we would deprecate these formatting functions, so in the next major version we wouldn't have them at all, since ResourceName classes are superior in static-type-checking and usability.
Metadata
Metadata
Assignees
Labels
priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.