Skip to content

Conversation

@yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/google-cloud-clients/google-cloud-iamcredentials/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:75bc07ef34a1de9895c18af54dc503ed3b3f3b52e85062e3360a979d2a0741e7
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/iam/credentials/artman_iamcredentials_v1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java.
synthtool > Running java formatter on 10 files
synthtool > Running java formatter on 1 files
synthtool > Running java formatter on 23 files
synthtool > Cleaned up 0 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation requested a review from a team as a code owner February 2, 2019 08:41
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 2, 2019
@sduskis
Copy link
Contributor

sduskis commented Feb 6, 2019

There are backwards incompatible changes in this PR. Is that ok?

@sduskis
Copy link
Contributor

sduskis commented Feb 8, 2019

@andreamlin, it looks like we need to restore format* methods here.

@andreamlin
Copy link
Contributor

@sduskis Yes thanks for FYI! I was wondering what other clients would need this backwards-supporting change.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Feb 9, 2019
@sduskis sduskis added status: blocked Resolving the issue is dependent on other work. and removed 🚨 This issue needs some love. labels Feb 11, 2019
@andreamlin
Copy link
Contributor

@sduskis This should be fixed if we run synthtool again (updated artman to remove the bug that had removed those functions).

@andreamlin andreamlin removed the status: blocked Resolving the issue is dependent on other work. label Feb 13, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Feb 13, 2019
@sduskis sduskis closed this Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants