common: update instance metadata on getMetadata call#1563
Merged
callmehiphop merged 1 commit intogoogleapis:masterfrom Sep 2, 2016
Merged
common: update instance metadata on getMetadata call#1563callmehiphop merged 1 commit intogoogleapis:masterfrom
getMetadata call#1563callmehiphop merged 1 commit intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
miguelvelezsa
pushed a commit
that referenced
this pull request
Jul 23, 2025
* Update release-please-config.json * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl
pushed a commit
that referenced
this pull request
Feb 26, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Mar 11, 2026
* feat: add BigQuery configuration for subscriptions PiperOrigin-RevId: 449031535 Source-Link: googleapis/googleapis@feec34d Source-Link: googleapis/googleapis-gen@89664e9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODk2NjRlOTcwOGMxOWQ1MzJjNjNmN2ExNmZkNzljYjYzMWQ4N2FhMSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
GautamSharda
pushed a commit
that referenced
this pull request
Mar 11, 2026
🤖 I have created a release *beep* *boop* --- ## [3.0.0](googleapis/nodejs-pubsub@v2.19.4...v3.0.0) (2022-05-26) ### ⚠ BREAKING CHANGES * update library to use Node 12 (#1564) ### Features * add BigQuery configuration for subscriptions ([#1563](googleapis/nodejs-pubsub#1563)) ([29d38a1](googleapis/nodejs-pubsub@29d38a1)) ### Bug Fixes * **deps:** update dependency google-gax to v2.30.4 ([#1555](googleapis/nodejs-pubsub#1555)) ([518fce1](googleapis/nodejs-pubsub@518fce1)) * fixes for dynamic routing and streaming descriptors ([#1566](googleapis/nodejs-pubsub#1566)) ([158c606](googleapis/nodejs-pubsub@158c606)) ### Build System * update library to use Node 12 ([#1564](googleapis/nodejs-pubsub#1564)) ([adb4319](googleapis/nodejs-pubsub@adb4319)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
GautamSharda
pushed a commit
that referenced
this pull request
Mar 12, 2026
4 tasks
sofisl
added a commit
that referenced
this pull request
Mar 17, 2026
* Update release-please-config.json * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl
pushed a commit
that referenced
this pull request
Mar 17, 2026
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [mocha](https://mochajs.org/) ([source](https://togithub.com/mochajs/mocha)) | [`^10.3.0` -> `^10.4.0`](https://renovatebot.com/diffs/npm/mocha/10.3.0/10.4.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mochajs/mocha (mocha)</summary> ### [`v10.4.0`](https://togithub.com/mochajs/mocha/blob/HEAD/CHANGELOG.md#1040--2024-03-26) [Compare Source](https://togithub.com/mochajs/mocha/compare/v10.3.0...v10.4.0) ##### 🎉 Enhancements - [#​4829](https://togithub.com/mochajs/mocha/pull/4829) feat: include `.cause` stacks in the error stack traces ([**@​voxpelli**](https://togithub.com/voxpelli)) - [#​4985](https://togithub.com/mochajs/mocha/pull/4985) feat: add file path to xunit reporter ([**@​bmish**](https://togithub.com/bmish)) ##### 🐛 Fixes - [#​5074](https://togithub.com/mochajs/mocha/pull/5074) fix: harden error handling in `lib/cli/run.js` ([**@​stalet**](https://togithub.com/stalet)) ##### 🔩 Other - [#​5077](https://togithub.com/mochajs/mocha/pull/5077) chore: add mtfoley/pr-compliance-action ([**@​JoshuaKGoldberg**](https://togithub.com/JoshuaKGoldberg)) - [#​5060](https://togithub.com/mochajs/mocha/pull/5060) chore: migrate ESLint config to flat config ([**@​JoshuaKGoldberg**](https://togithub.com/JoshuaKGoldberg)) - [#​5095](https://togithub.com/mochajs/mocha/pull/5095) chore: revert [#​5069](https://togithub.com/mochajs/mocha/pull/5069) to restore Netlify builds ([**@​voxpelli**](https://togithub.com/voxpelli)) - [#​5097](https://togithub.com/mochajs/mocha/pull/5097) docs: add sponsored to sponsorship link rels ([**@​JoshuaKGoldberg**](https://togithub.com/JoshuaKGoldberg)) - [#​5093](https://togithub.com/mochajs/mocha/pull/5093) chore: add 'status: in triage' label to issue templates and docs ([**@​JoshuaKGoldberg**](https://togithub.com/JoshuaKGoldberg)) - [#​5083](https://togithub.com/mochajs/mocha/pull/5083) docs: fix CHANGELOG.md headings to start with a root-level h1 ([**@​JoshuaKGoldberg**](https://togithub.com/JoshuaKGoldberg)) - [#​5100](https://togithub.com/mochajs/mocha/pull/5100) chore: fix header generation and production build crashes ([**@​JoshuaKGoldberg**](https://togithub.com/JoshuaKGoldberg)) - [#​5104](https://togithub.com/mochajs/mocha/pull/5104) chore: bump ESLint ecmaVersion to 2020 ([**@​JoshuaKGoldberg**](https://togithub.com/JoshuaKGoldberg)) - [#​5116](https://togithub.com/mochajs/mocha/pull/5116) fix: eleventy template builds crash with 'unexpected token at ": string, msg..."' ([**@​LcsK**](https://togithub.com/LcsK)) - [#​4869](https://togithub.com/mochajs/mocha/pull/4869) docs: fix documentation concerning glob expansion on UNIX ([**@​binki**](https://togithub.com/binki)) - [#​5122](https://togithub.com/mochajs/mocha/pull/5122) test: fix xunit integration test ([**@​voxpelli**](https://togithub.com/voxpelli)) - [#​5123](https://togithub.com/mochajs/mocha/pull/5123) chore: activate dependabot for workflows ([**@​voxpelli**](https://togithub.com/voxpelli)) - [#​5125](https://togithub.com/mochajs/mocha/pull/5125) build(deps): bump the github-actions group with 2 updates ([**@​dependabot**](https://togithub.com/dependabot)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/gapic-generator-typescript). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
GautamSharda
pushed a commit
that referenced
this pull request
Mar 23, 2026
**Summary:** The user should be able to set the universe domain so that outgoing calls work with a different Google Cloud Universe. Right now, if the user specifies a universe domain then it will not get used and the request will just be sent to the default Bigtable endpoint. **Changes:** `src/index.ts:` The change here is that when a custom url is not provided, but a universe domain is provided then the servicePath will use the universe domain provided. This is done for each Gapic client and ensures requests will be made to the universe domain instead of the default Bigtable service. `system-test/service-path.ts`: Two tests are added to ensure the service path is always set correctly. For instance, when a custom endpoint is provided then the service path will still always be that custom endpoint. When a custom endpoint is NOT provided, but a universe domain is provided then the service path is set to use the universe domain instead of the default endpoint. **Alternatives:** 1. Instead of requiring the user to set the universe domain for each Gapic client, we could expose a `universeDomain` option that would apply to all clients. While this would make things easier for users, it is an API change so it is not reversible. For now we should not change the API since users already have a way to specify the universe domains for the Gapic clients. We can always add this option later. 2. When a custom endpoint is not provided then in the handwritten layer we could not provide a service path. The Pros of this option is that we can rely on the code in the Gapic layer for building the service path instead of creating the getDomain function introducing duplicate code and this would reduce technical debt. The main problem with this option is that it means [providedCustomServicePath](https://togithub.com/googleapis/nodejs-bigtable/blob/2fdf98f9398761046f41bd58e00258f0d4963a3d/src/v2/bigtable_client.ts#L132) will now be undefined and this value is used in the grpc stub so we don't know how such a change might affect the outgoing API calls. The code to implement this alternative also gets messy if Alternative 1 isn't adopted as well.
GautamSharda
pushed a commit
that referenced
this pull request
Mar 25, 2026
**Summary:** The user should be able to set the universe domain so that outgoing calls work with a different Google Cloud Universe. Right now, if the user specifies a universe domain then it will not get used and the request will just be sent to the default Bigtable endpoint. **Changes:** `src/index.ts:` The change here is that when a custom url is not provided, but a universe domain is provided then the servicePath will use the universe domain provided. This is done for each Gapic client and ensures requests will be made to the universe domain instead of the default Bigtable service. `system-test/service-path.ts`: Two tests are added to ensure the service path is always set correctly. For instance, when a custom endpoint is provided then the service path will still always be that custom endpoint. When a custom endpoint is NOT provided, but a universe domain is provided then the service path is set to use the universe domain instead of the default endpoint. **Alternatives:** 1. Instead of requiring the user to set the universe domain for each Gapic client, we could expose a `universeDomain` option that would apply to all clients. While this would make things easier for users, it is an API change so it is not reversible. For now we should not change the API since users already have a way to specify the universe domains for the Gapic clients. We can always add this option later. 2. When a custom endpoint is not provided then in the handwritten layer we could not provide a service path. The Pros of this option is that we can rely on the code in the Gapic layer for building the service path instead of creating the getDomain function introducing duplicate code and this would reduce technical debt. The main problem with this option is that it means [providedCustomServicePath](https://togithub.com/googleapis/nodejs-bigtable/blob/2fdf98f9398761046f41bd58e00258f0d4963a3d/src/v2/bigtable_client.ts#L132) will now be undefined and this value is used in the grpc stub so we don't know how such a change might affect the outgoing API calls. The code to implement this alternative also gets messy if Alternative 1 isn't adopted as well.
feywind
pushed a commit
that referenced
this pull request
Mar 27, 2026
🤖 I have created a release *beep* *boop* --- ## [3.0.0](googleapis/nodejs-pubsub@v2.19.4...v3.0.0) (2022-05-26) ### ⚠ BREAKING CHANGES * update library to use Node 12 (#1564) ### Features * add BigQuery configuration for subscriptions ([#1563](googleapis/nodejs-pubsub#1563)) ([29d38a1](googleapis/nodejs-pubsub@29d38a1)) ### Bug Fixes * **deps:** update dependency google-gax to v2.30.4 ([#1555](googleapis/nodejs-pubsub#1555)) ([518fce1](googleapis/nodejs-pubsub@518fce1)) * fixes for dynamic routing and streaming descriptors ([#1566](googleapis/nodejs-pubsub#1566)) ([158c606](googleapis/nodejs-pubsub@158c606)) ### Build System * update library to use Node 12 ([#1564](googleapis/nodejs-pubsub#1564)) ([cf4ac04](googleapis/nodejs-pubsub@cf4ac04)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
shivanee-p
pushed a commit
that referenced
this pull request
Mar 27, 2026
](https://renovatebot.com){kind=link}
**Summary:** The user should be able to set the universe domain so that outgoing calls work with a different Google Cloud Universe. Right now, if the user specifies a universe domain then it will not get used and the request will just be sent to the default Bigtable endpoint. **Changes:** `src/index.ts:` The change here is that when a custom url is not provided, but a universe domain is provided then the servicePath will use the universe domain provided. This is done for each Gapic client and ensures requests will be made to the universe domain instead of the default Bigtable service. `system-test/service-path.ts`: Two tests are added to ensure the service path is always set correctly. For instance, when a custom endpoint is provided then the service path will still always be that custom endpoint. When a custom endpoint is NOT provided, but a universe domain is provided then the service path is set to use the universe domain instead of the default endpoint. **Alternatives:** 1. Instead of requiring the user to set the universe domain for each Gapic client, we could expose a `universeDomain` option that would apply to all clients. While this would make things easier for users, it is an API change so it is not reversible. For now we should not change the API since users already have a way to specify the universe domains for the Gapic clients. We can always add this option later. 2. When a custom endpoint is not provided then in the handwritten layer we could not provide a service path. The Pros of this option is that we can rely on the code in the Gapic layer for building the service path instead of creating the getDomain function introducing duplicate code and this would reduce technical debt. The main problem with this option is that it means [providedCustomServicePath](https://togithub.com/googleapis/nodejs-bigtable/blob/2fdf98f9398761046f41bd58e00258f0d4963a3d/src/v2/bigtable_client.ts#L132) will now be undefined and this value is used in the grpc stub so we don't know how such a change might affect the outgoing API calls. The code to implement this alternative also gets messy if Alternative 1 isn't adopted as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1418