This repository was archived by the owner on Mar 17, 2026. It is now read-only.
Conversation
|
Warning: This pull request is touching the following templated files:
|
product-auto-label
bot
added
size: l
product-auto-label
bot
added
size: m
product-auto-label
bot
added
size: l
feywind
added
the
do not merge
Collaborator
|
I talked it over with @sofisl , I think we're going to hold this back just a bit until I can figure out the timing with the Pub/Sub team. |
feywind
removed
the
do not merge
Collaborator
|
This is cleared for when CI passes :) |
feywind
reviewed
May 18, 2022
test/subscription.ts
Outdated
| assert.strictEqual(err, fakeErr); | ||
| done(); | ||
| }); | ||
| subscription?.close!(), |
Collaborator
There was a problem hiding this comment.
I think for whatever reason, the ?. here is failing, so the test never concludes. I'm unsure why it would be undefined here and not before, but it's probably a more discoverable test failure if it has an undefined object exception anyhow (i.e. I'd just switch subscription back to subscription! for the Partial).
alexander-fenster
approved these changes
May 18, 2022
alexander-fenster
approved these changes
May 18, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 26, 2022
🤖 I have created a release *beep* *boop* --- ## [3.0.0](v2.19.4...v3.0.0) (2022-05-26) ### ⚠ BREAKING CHANGES * update library to use Node 12 (#1564) ### Features * add BigQuery configuration for subscriptions ([#1563](#1563)) ([29d38a1](29d38a1)) ### Bug Fixes * **deps:** update dependency google-gax to v2.30.4 ([#1555](#1555)) ([518fce1](518fce1)) * fixes for dynamic routing and streaming descriptors ([#1566](#1566)) ([158c606](158c606)) ### Build System * update library to use Node 12 ([#1564](#1564)) ([adb4319](adb4319)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
feywind
added a commit
to feywind/nodejs-pubsub
that referenced
this pull request
Sep 27, 2022
This reverts commit adb4319.
GautamSharda
pushed a commit
to googleapis/google-cloud-node
that referenced
this pull request
Mar 11, 2026
🤖 I have created a release *beep* *boop* --- ## [3.0.0](googleapis/nodejs-pubsub@v2.19.4...v3.0.0) (2022-05-26) ### ⚠ BREAKING CHANGES * update library to use Node 12 (#1564) ### Features * add BigQuery configuration for subscriptions ([#1563](googleapis/nodejs-pubsub#1563)) ([29d38a1](googleapis/nodejs-pubsub@29d38a1)) ### Bug Fixes * **deps:** update dependency google-gax to v2.30.4 ([#1555](googleapis/nodejs-pubsub#1555)) ([518fce1](googleapis/nodejs-pubsub@518fce1)) * fixes for dynamic routing and streaming descriptors ([#1566](googleapis/nodejs-pubsub#1566)) ([158c606](googleapis/nodejs-pubsub@158c606)) ### Build System * update library to use Node 12 ([#1564](googleapis/nodejs-pubsub#1564)) ([adb4319](googleapis/nodejs-pubsub@adb4319)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate library to Node 12