Update discovery document and documentation for Requester Pays#694
Update discovery document and documentation for Requester Pays#694dwsupplee merged 9 commits intogoogleapis:masterfrom jdpedrie:storage-requester-pays-additions
Conversation
googlebot
added
the
cla: yes
src/Storage/Bucket.php
Outdated
| public function createNotification($topic, array $options = []) | ||
| { | ||
| $res = $this->connection->insertNotification($options + [ | ||
| $res = $this->connection->insertNotification($options + array_filter([ |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
src/Storage/StorageClient.php
Outdated
| $bucket | ||
| ); | ||
| function (array $bucket) use ($requesterPays) { | ||
| return new Bucket($this->connection, $bucket['name'], $bucket, $requesterPays); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
src/Storage/StorageClient.php
Outdated
| $name, | ||
| $response | ||
| $response, | ||
| $requesterPays |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@dwsupplee updated. |
|
@frankyn, I updated the documentation in this pull request. PTAL |
| { | ||
| $this->connection | ||
| ->insertNotification([ | ||
| 'userProject' => null, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
src/Storage/StorageClient.php
Outdated
| * be either 'full' or 'noAcl'. | ||
| * @type string $fields Selector which will cause the response to only | ||
| * return the specified fields. | ||
| * @type string $userProject The user project to be used for |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@frankyn should be good now! |
| * | ||
| * @param string $name The name of the bucket to request. | ||
| * @param string|bool $requesterPays If true, the current Project ID | ||
| * @param string|bool $userProject If true, the current Project ID |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| { | ||
| $this->connection | ||
| ->insertNotification([ | ||
| 'userProject' => null, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| // to short circuit all the response handling and get back to the assertion with the query string. | ||
| throw new \Exception($request->getUri()->getQuery()); | ||
| } | ||
| } No newline at end of file |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -0,0 +1,430 @@ | |||
| <?php | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
4 participants
Most of the remaining Requester Pays methods were implemented with a discovery document update. Additional documentation has been added where appropriate, and a unit test class has been added to demonstrate that the
userProjectquery parameter is added where appropriate.Closes #699, #696.