Merged
Conversation
googlebot
added
the
cla: yes
Change permissions values in code examples to use correct values. List permissions values that can be checked on test_permissions docs. Add additional checks on acceptance tests to ensure the account has proper permissions to update the IAM policy. By default, a service account will not have owner permissions, so one must change the service account to an owner to get passing tests. https://cloud.google.com/pubsub/access_control#tbl_perm
Member
|
Looks like everything has been straightened out! Great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build is failing due to a permissions change in getting and setting the IAM policy. This change adds some additional checks to the tests to ensure that the account has permissions to access and update the policy.
Correct the permissions values used in the code examples to use the correct permissions, and list the permissions values that can be checked on
test_permissionsdocumentation.