Skip to content

fix(resumable-media): fix failing unit tests by dropping Python 3.4, add Python 3.8 #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
plamut merged 6 commits into from
Jan 9, 2020
Merged

fix(resumable-media): fix failing unit tests by dropping Python 3.4, add Python 3.8 #118

plamut merged 6 commits into from
Jan 9, 2020

Conversation

@plamut
Copy link
Contributor

@plamut plamut commented Jan 8, 2020

Fixes #117.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 8, 2020
busunkim96
busunkim96 reviewed Jan 8, 2020
View reviewed changes
noxfile.py Outdated


@nox.session(python=['2.7', '3.4', '3.5', '3.6', '3.7'])
@nox.session(python=['3.5', '3.6', '3.7'])
Copy link
Contributor

@busunkim96 busunkim96 Jan 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind dropping 3.8 in here as well?

Copy link
Contributor Author

@plamut plamut Jan 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

I also bumped the Python versions in other sessions to 3.8, as I believe this a standard practice (running misc. checks with the latest supported version).

@crwilcox
Copy link
Collaborator

crwilcox commented Jan 8, 2020 •
edited
Loading

Before removing python 2.7 from resumable media we would need to remove it from google-cloud-storage and google-cloud-bigquery as it is one of our helper packages.

@plamut
Copy link
Contributor Author

plamut commented Jan 8, 2020

I can revert dropping Python 2.7, that commit that introduced a byte string template is optional.

Yes, I can add Python 3.8, too.

@plamut plamut requested a review from busunkim96 January 8, 2020 19:30
@plamut plamut changed the title fix(resumable-media): fix failing unit tests by dropping support for Python <=3.4 fix(resumable-media): fix failing unit tests by dropping Python 3.4, add Python 3.8 Jan 8, 2020
@plamut plamut mentioned this pull request Jan 8, 2020
Merged
@plamut plamut merged commit 1edb974 into googleapis:master Jan 9, 2020
@plamut plamut deleted the iss-117 branch January 9, 2020 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crwilcox crwilcox crwilcox approved these changes

@busunkim96 busunkim96 Awaiting requested review from busunkim96

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unit test suite under Python 3.4 fails if run after other suites

4 participants

@plamut @crwilcox @busunkim96 @googlebot