Skip to content

fix(resumable-media): fix failing unit tests by dropping Python 3.4, add Python 3.8 #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plamut merged 6 commits into from
Jan 9, 2020
Merged

fix(resumable-media): fix failing unit tests by dropping Python 3.4, add Python 3.8 #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
13528bd
chore(resumable-media): remove Python <=3.4 support
plamut Jan 8, 2020
e56fb9c
Use a byte template to create multipart payload
plamut Jan 8, 2020
88a9ec3
Blacken system tests
plamut Jan 8, 2020
2ea2f6f
Revert "Use a byte template to create multipart payload"
plamut Jan 8, 2020
efaba93
Add back Python 2.7 support
plamut Jan 8, 2020
ff40d0a
Add support for Python 3.8
plamut Jan 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ See the `docs`_ for examples and usage.

Supported Python Versions
-------------------------
Python >= 3.4
Python >= 3.5

Deprecated Python Versions
--------------------------
Expand Down
16 changes: 8 additions & 8 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
GOOGLE_AUTH = 'google-auth >= 0.10.0'


@nox.session(python=['2.7', '3.4', '3.5', '3.6', '3.7'])
@nox.session(python=['2.7', '3.5', '3.6', '3.7', '3.8'])
def unit_tests(session):
"""Run the unit test suite."""

Expand All @@ -49,7 +49,7 @@ def unit_tests(session):
)


@nox.session(python='3.6')
@nox.session(python='3.8')
def docs(session):
"""Build the docs."""

Expand All @@ -66,7 +66,7 @@ def docs(session):
session.run('bash', os.path.join('scripts', 'build_docs.sh'))


@nox.session(python='3.6')
@nox.session(python='3.8')
def doctest(session):
"""Run the doctests."""
# Install Sphinx and other dependencies.
Expand All @@ -88,7 +88,7 @@ def doctest(session):
)


@nox.session(python='3.6')
@nox.session(python='3.8')
def lint(session):
"""Run flake8.

Expand All @@ -105,21 +105,21 @@ def lint(session):
session.run("black", "--check", os.path.join("google", "resumable_media"), "tests")


@nox.session(python='3.6')
@nox.session(python='3.8')
def lint_setup_py(session):
"""Verify that setup.py is valid (including RST check)."""
session.install('docutils', 'Pygments')
session.run(
'python', 'setup.py', 'check', '--restructuredtext', '--strict')


@nox.session(python='3.6')
@nox.session(python='3.8')
def blacken(session):
session.install("black")
session.run("black", os.path.join("google", "resumable_media"), "tests")


@nox.session(python=['2.7', '3.6'])
@nox.session(python=['2.7', '3.8'])
def system_tests(session):
"""Run the system test suite."""

Expand Down Expand Up @@ -148,7 +148,7 @@ def system_tests(session):
)


@nox.session(python='3.6')
@nox.session(python='3.8')
def cover(session):
"""Run the final coverage report.

Expand Down
4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
zip_safe=False,
install_requires=REQUIREMENTS,
extras_require=EXTRAS_REQUIRE,
python_requires='>=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*',
python_requires='>=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*,!=3.4.*',
classifiers=[
'Development Status :: 3 - Alpha',
'Intended Audience :: Developers',
Expand All @@ -58,10 +58,10 @@
'Programming Language :: Python :: 2',
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.4',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
'Topic :: Internet',
],
)
2 changes: 1 addition & 1 deletion tests/system/requests/test_upload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def get_upload_id(upload_url):
parse_result = urllib_parse.urlparse(upload_url)
parsed_query = urllib_parse.parse_qs(parse_result.query)
# NOTE: We are unpacking here, so asserting exactly one match.
upload_id, = parsed_query[u"upload_id"]
(upload_id,) = parsed_query[u"upload_id"]
return upload_id


Expand Down