chore(deps): consolidate dependency upgrades#4344
Conversation
Combines the following open dependency PRs into a single update: - maven-compiler-plugin: 3.14.1 → 3.15.0 (#4325) - libraries-bom: 26.74.0 → 26.75.0 (#4324) - google-cloud-monitoring: 3.83.0 → 3.85.0 (#4323, #4322) - proto-google-cloud-trace-v1: 2.82.0 → 2.84.0 (#4321) - google-cloud-spanner (samples/benchmarks): 6.107.0 → 6.110.0 (#4318) - exec-maven-plugin: 3.6.2 → 3.6.3 (#4277) - opentelemetry.version: 1.56.0 → 1.59.0 (#4255) - byte-buddy-agent: 1.18.1 → 1.18.4 (#4245) - actions/checkout: v4/v5 → v6 (#4240) - google-cloud-trace: 2.79.0 → 2.84.0 (#4173, #4228)
product-auto-label
bot
added
size: s
Summary of ChangesHello @rahul2393, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request centralizes and applies a series of dependency upgrades across the project's Maven configuration files. The primary goal is to ensure all components are running on up-to-date versions, improving stability, security, and leveraging the latest features from various libraries and plugins. This consolidation simplifies the update process by addressing multiple pending dependency bumps in one go. Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request consolidates several dependency upgrades across multiple pom.xml files. The changes are straightforward version bumps. I've identified a couple of opportunities to improve maintainability by using properties for dependency versions that are updated together, which I've detailed in the comments.
| <dependency> | ||
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>google-cloud-trace</artifactId> | ||
| <version>2.79.0</version> | ||
| <version>2.84.0</version> |
There was a problem hiding this comment.
The version for google-cloud-trace is hardcoded. This version is now aligned with proto-google-cloud-trace-v1 (updated to 2.84.0 later in this file). To improve maintainability, consider defining a property for this version in the <properties> section and using it in both places to ensure consistency.
| <dependency> | ||
| <groupId>net.bytebuddy</groupId> | ||
| <artifactId>byte-buddy-agent</artifactId> | ||
| <version>1.18.1</version> | ||
| <version>1.18.4</version> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
The version for byte-buddy-agent is now 1.18.4, which matches the version of the byte-buddy dependency. To improve maintainability, consider defining a property for this version (e.g., <byte-buddy.version>1.18.4</byte-buddy.version>) in the <properties> section and using it for both dependencies.
| <dependency> | ||
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>google-cloud-trace</artifactId> | ||
| <version>2.79.0</version> | ||
| <version>2.84.0</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.google.api.grpc</groupId> | ||
| <artifactId>proto-google-cloud-trace-v1</artifactId> | ||
| <version>2.82.0</version> | ||
| <version>2.84.0</version> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
The versions for google-cloud-trace and proto-google-cloud-trace-v1 are now aligned to 2.84.0. To improve maintainability and ensure they stay in sync, consider defining a property for this version (e.g., <google.cloud.trace.version>2.84.0</google.cloud.trace.version>) in the <properties> section and using it for both dependencies.
rahul2393
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
4 participants
Combines the following open dependency PRs into a single update: