Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/hermetic_library_generation.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
else
echo "SHOULD_RUN=true" >> $GITHUB_ENV
fi
- uses: actions/checkout@v5
- uses: actions/checkout@v6
if: env.SHOULD_RUN == 'true'
with:
fetch-depth: 0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- 9020:9020

steps:
- uses: actions/checkout@v5
- uses: actions/checkout@v6
- uses: stCarolas/setup-maven@v5
with:
maven-version: 3.8.1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unmanaged_dependency_check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ jobs:
unmanaged_dependency_check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v5
- uses: actions/checkout@v6
- uses: actions/setup-java@v5
with:
distribution: temurin
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ If you are using Maven with [BOM][libraries-bom], add this to your pom.xml file:
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>libraries-bom</artifactId>
<version>26.74.0</version>
<version>26.75.0</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand All @@ -41,7 +41,7 @@ If you are using Maven without the BOM, add this to your dependencies:
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-spanner</artifactId>
<version>6.107.0</version>
<version>6.110.0</version>
</dependency>

```
Expand Down
8 changes: 4 additions & 4 deletions benchmarks/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<junixsocket.version>2.10.1</junixsocket.version>
<opentelemetry.version>1.56.0</opentelemetry.version>
<google.cloud.monitoring.version>3.83.0</google.cloud.monitoring.version>
<opentelemetry.version>1.59.0</opentelemetry.version>
<google.cloud.monitoring.version>3.85.0</google.cloud.monitoring.version>
</properties>

<dependencies>
Expand Down Expand Up @@ -91,7 +91,7 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-spanner</artifactId>
<version>6.107.0</version>
<version>6.110.0</version>
</dependency>
<dependency>
<groupId>com.google.auto.value</groupId>
Expand Down Expand Up @@ -127,7 +127,7 @@
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
<version>3.6.2</version>
<version>3.6.3</version>
<configuration>
<mainClass>com.google.cloud.spanner.benchmark.LatencyBenchmark</mainClass>
<cleanupDaemonThreads>false</cleanupDaemonThreads>
Expand Down
2 changes: 1 addition & 1 deletion google-cloud-spanner-bom/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.14.1</version>
<version>3.15.0</version>
<configuration>
<source>1.8</source>
<target>1.8</target>
Expand Down
4 changes: 2 additions & 2 deletions google-cloud-spanner-executor/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-trace</artifactId>
<version>2.79.0</version>
<version>2.84.0</version>
Comment on lines 74 to +77
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The version for google-cloud-trace is hardcoded. This version is now aligned with proto-google-cloud-trace-v1 (updated to 2.84.0 later in this file). To improve maintainability, consider defining a property for this version in the <properties> section and using it in both places to ensure consistency.

<!-- Version will be managed by guava -->
<exclusions>
<exclusion>
Expand Down Expand Up @@ -154,7 +154,7 @@
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-cloud-trace-v1</artifactId>
<version>2.82.0</version>
<version>2.84.0</version>
<!-- Version will be managed by guava -->
<exclusions>
<exclusion>
Expand Down
8 changes: 4 additions & 4 deletions google-cloud-spanner/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<properties>
<site.installationModule>google-cloud-spanner</site.installationModule>
<opencensus.version>0.31.1</opencensus.version>
<google.cloud.monitoring.version>3.83.0</google.cloud.monitoring.version>
<google.cloud.monitoring.version>3.85.0</google.cloud.monitoring.version>
<spanner.testenv.config.class>com.google.cloud.spanner.GceTestEnvConfig</spanner.testenv.config.class>
<spanner.testenv.instance>projects/gcloud-devel/instances/spanner-testing-east1</spanner.testenv.instance>
<spanner.gce.config.project_id>gcloud-devel</spanner.gce.config.project_id>
Expand Down Expand Up @@ -448,7 +448,7 @@
<dependency>
<groupId>net.bytebuddy</groupId>
<artifactId>byte-buddy-agent</artifactId>
<version>1.18.1</version>
<version>1.18.4</version>
<scope>test</scope>
</dependency>
Comment on lines 448 to 453
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The version for byte-buddy-agent is now 1.18.4, which matches the version of the byte-buddy dependency. To improve maintainability, consider defining a property for this version (e.g., <byte-buddy.version>1.18.4</byte-buddy.version>) in the <properties> section and using it for both dependencies.


Expand Down Expand Up @@ -544,13 +544,13 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-trace</artifactId>
<version>2.79.0</version>
<version>2.84.0</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-cloud-trace-v1</artifactId>
<version>2.82.0</version>
<version>2.84.0</version>
<scope>test</scope>
</dependency>
Comment on lines 544 to 555
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The versions for google-cloud-trace and proto-google-cloud-trace-v1 are now aligned to 2.84.0. To improve maintainability and ensure they stay in sync, consider defining a property for this version (e.g., <google.cloud.trace.version>2.84.0</google.cloud.trace.version>) in the <properties> section and using it for both dependencies.

</dependencies>
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.14.1</version>
<version>3.15.0</version>
<configuration>
<source>1.8</source>
<target>1.8</target>
Expand Down
6 changes: 3 additions & 3 deletions samples/install-without-bom/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
<maven.compiler.source>1.8</maven.compiler.source>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<opencensus.version>0.31.1</opencensus.version>
<trace.version>2.79.0</trace.version>
<cloudmonitoring.version>3.83.0</cloudmonitoring.version>
<trace.version>2.84.0</trace.version>
<cloudmonitoring.version>3.85.0</cloudmonitoring.version>
</properties>


Expand All @@ -33,7 +33,7 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-spanner</artifactId>
<version>6.107.0</version>
<version>6.110.0</version>
</dependency>
<!-- [END spanner_install_without_bom] -->

Expand Down
4 changes: 2 additions & 2 deletions samples/snapshot/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
<maven.compiler.source>1.8</maven.compiler.source>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<opencensus.version>0.31.1</opencensus.version>
<trace.version>2.79.0</trace.version>
<cloudmonitoring.version>3.83.0</cloudmonitoring.version>
<trace.version>2.84.0</trace.version>
<cloudmonitoring.version>3.85.0</cloudmonitoring.version>
</properties>

<dependencies>
Expand Down
2 changes: 1 addition & 1 deletion samples/snippets/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>libraries-bom</artifactId>
<version>26.74.0</version>
<version>26.75.0</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down
Loading