-
Notifications
You must be signed in to change notification settings - Fork 137
chore(deps): consolidate dependency upgrades #4344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,7 +16,7 @@ | |
| <properties> | ||
| <site.installationModule>google-cloud-spanner</site.installationModule> | ||
| <opencensus.version>0.31.1</opencensus.version> | ||
| <google.cloud.monitoring.version>3.83.0</google.cloud.monitoring.version> | ||
| <google.cloud.monitoring.version>3.85.0</google.cloud.monitoring.version> | ||
| <spanner.testenv.config.class>com.google.cloud.spanner.GceTestEnvConfig</spanner.testenv.config.class> | ||
| <spanner.testenv.instance>projects/gcloud-devel/instances/spanner-testing-east1</spanner.testenv.instance> | ||
| <spanner.gce.config.project_id>gcloud-devel</spanner.gce.config.project_id> | ||
|
|
@@ -448,7 +448,7 @@ | |
| <dependency> | ||
| <groupId>net.bytebuddy</groupId> | ||
| <artifactId>byte-buddy-agent</artifactId> | ||
| <version>1.18.1</version> | ||
| <version>1.18.4</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
|
Comment on lines
448
to
453
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
|
|
@@ -544,13 +544,13 @@ | |
| <dependency> | ||
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>google-cloud-trace</artifactId> | ||
| <version>2.79.0</version> | ||
| <version>2.84.0</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.google.api.grpc</groupId> | ||
| <artifactId>proto-google-cloud-trace-v1</artifactId> | ||
| <version>2.82.0</version> | ||
| <version>2.84.0</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
|
Comment on lines
544
to
555
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The versions for |
||
| </dependencies> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version for
google-cloud-traceis hardcoded. This version is now aligned withproto-google-cloud-trace-v1(updated to2.84.0later in this file). To improve maintainability, consider defining a property for this version in the<properties>section and using it in both places to ensure consistency.