Skip to content

chore: clean up BigQueryStorage import checks #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Linchin wants to merge 3 commits into from
Closed

chore: clean up BigQueryStorage import checks #1680

Linchin wants to merge 3 commits into from

Conversation

@Linchin
Copy link
Contributor

@Linchin Linchin commented Oct 11, 2023 •
edited
Loading

Follow up of #1679

Also part of fixing #1430, this PR cleans up code that verifies BigQueryStorage extra can be successfully imported. It also:

  • Modifies some lines to comply with PEP-8 line length limit
  • Adds unit test for the added method

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1430 🦕

@Linchin Linchin added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 11, 2023
@Linchin Linchin requested review from a team as code owners October 11, 2023 22:34
@Linchin Linchin requested a review from shollyman October 11, 2023 22:34
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels Oct 11, 2023
@Linchin Linchin removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 11, 2023
@Linchin Linchin requested a review from chalmerlowe October 11, 2023 23:30
@Linchin Linchin added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 11, 2023
@Linchin Linchin removed the request for review from shollyman October 11, 2023 23:40
@Linchin Linchin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 11, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 11, 2023
tswast
tswast requested changes Oct 13, 2023
View reviewed changes
@Linchin Linchin mentioned this pull request Oct 23, 2023
Merged
4 tasks
Linchin added a commit to Linchin/python-bigquery that referenced this pull request Oct 24, 2023
@Linchin
address comments in googleapis#1680
0a3a86d
@Linchin
Copy link
Contributor Author

Linchin commented Oct 24, 2023

Closed due to too much merge conflicts, use #1699 instead.

@Linchin Linchin closed this Oct 24, 2023
tswast pushed a commit that referenced this pull request Oct 26, 2023
@Linchin
chore: refactor BigQueryStorageVersions (#1699)
e8da978 
* chore: refactor BigQueryStorageVersions

* address comments in #1680

* add unit test
@Linchin Linchin deleted the bqstorage branch October 30, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast requested changes

@chalmerlowe chalmerlowe Awaiting requested review from chalmerlowe

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cleanup: Use logic from BQStorageVersions and PyarrowVersions instead of comparing version strings outside of _helpers

3 participants

@Linchin @tswast @yoshi-kokoro