Skip to content

chore: refactor BigQueryStorageVersions #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tswast merged 3 commits into from
Oct 26, 2023
Merged

chore: refactor BigQueryStorageVersions #1699

tswast merged 3 commits into from
Oct 26, 2023

Conversation

@Linchin
Copy link
Contributor

@Linchin Linchin commented Oct 23, 2023 •
edited
Loading

Follow up of #1679
Replaces #1680, due to too much merge conflicts

Also part of fixing #1430, this PR cleans up code that verifies BigQueryStorage extra can be successfully imported. It also:

  • Modifies some lines to comply with PEP-8 line length limit
  • Adds unit test for the added method

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1430 🦕

@Linchin Linchin requested review from a team as code owners October 23, 2023 21:48
@Linchin Linchin requested a review from alvarowolfx October 23, 2023 21:48
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery API. labels Oct 23, 2023
@Linchin Linchin requested review from tswast and removed request for alvarowolfx October 23, 2023 21:56
@Linchin Linchin added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 23, 2023
@Linchin Linchin mentioned this pull request Oct 23, 2023
Closed
4 tasks
@Linchin Linchin removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 24, 2023
tswast
tswast approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, thanks.

@tswast tswast merged commit e8da978 into googleapis:main Oct 26, 2023
@Linchin Linchin deleted the bqstorageversion branch October 30, 2023 23:37
@kiraksi kiraksi mentioned this pull request Nov 2, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cleanup: Use logic from BQStorageVersions and PyarrowVersions instead of comparing version strings outside of _helpers

2 participants

@Linchin @tswast