Skip to content

fix(storage): remove expiration strict conversion #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 2 commits into from
Apr 16, 2020
Merged

fix(storage): remove expiration strict conversion #106

gcf-merge-on-green merged 2 commits into from
Apr 16, 2020

Conversation

@HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Apr 14, 2020

Fixes #105

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 14, 2020
@HemangChothani
Copy link
Contributor Author

HemangChothani commented Apr 14, 2020

Doc is failing because of 100 issue, so first need to merge 103 PR.

frankyn
frankyn approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HemangChothani LGTM!

(Thanks @andrewsg for picking up the review)

@frankyn frankyn added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 16, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 16, 2020
@gcf-merge-on-green
Copy link
Contributor

gcf-merge-on-green bot commented Apr 16, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green
Copy link
Contributor

gcf-merge-on-green bot commented Apr 16, 2020

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@HemangChothani HemangChothani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 16, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 16, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 9550dad into googleapis:master Apr 16, 2020
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@HemangChothani @cojenco
fix(storage): remove expiration strict conversion (googleapis#106)
3bd5bac 
Fixes googleapis#105
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@HemangChothani @cojenco
fix(storage): remove expiration strict conversion (googleapis#106)
0702055 
Fixes googleapis#105
@release-please release-please bot mentioned this pull request Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewsg andrewsg andrewsg approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

+1 more reviewer

@frankyn frankyn frankyn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

use converted expiration parameter for signed_query_params to generate_signed_url_v2

5 participants

@HemangChothani @andrewsg @frankyn @googlebot @yoshi-kokoro