Skip to content

fix(storage): remove expiration strict conversion #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcf-merge-on-green merged 2 commits into from
Apr 16, 2020
Merged

fix(storage): remove expiration strict conversion #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9031216
fix(storage): remove expiration strict conversion
HemangChothani Apr 14, 2020
dc05f58
Merge branch 'master' into storage_issue_105
frankyn Apr 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions google/cloud/storage/_signing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def get_signed_query_params_v2(credentials, expiration, string_to_sign):
service_account_name = credentials.signer_email
return {
"GoogleAccessId": service_account_name,
"Expires": str(expiration),
"Expires": expiration,
"Signature": signature,
}

Expand Down Expand Up @@ -384,7 +384,7 @@ def generate_signed_url_v2(
signature = _sign_message(string_to_sign, access_token, service_account_email)
signed_query_params = {
"GoogleAccessId": service_account_email,
"Expires": str(expiration),
"Expires": expiration_stamp,
"Signature": signature,
}
else:
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test__signing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ def test_it(self):

expected = {
"GoogleAccessId": account_name,
"Expires": str(expiration),
"Expires": expiration,
"Signature": base64.b64encode(sig_bytes),
}
self.assertEqual(result, expected)
Expand Down