Error components for ViewActivities#77
Merged
Merged
Conversation
keiffer01
changed the title
anan-ya-y
approved these changes
Jul 17, 2020
zghera
requested changes
Jul 20, 2020
Collaborator
Author
|
Re-requesting review for nontrivial changes to the file structure. The "Are there more details that are more relevant" section has been updated accordingly. |
zghera
approved these changes
Jul 22, 2020
anan-ya-y
approved these changes
Jul 22, 2020
HiramSilvey
requested changes
Jul 24, 2020
beiebi0
approved these changes
Jul 27, 2020
HiramSilvey
approved these changes
Jul 27, 2020
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is a quick description of the change?
This PR is an extension of #76, which abstracts the error messages into their own components, with buttons that redirect to the VIEW_TRIPS page.
Is this fixing an issue?
Fixes #74
Are there more details that are relevant?
The directory
components/Errorswas created for various error components. The following three were created:Descriptions of each are given in the respective component's file. Each one also has a button redirecting the user back to their View Trips page.
Check lists (check
xin[ ]of list items)The rendering of these error messages were tested as in PR #76.
Any additional comments?
GIF below (it is dark because I was using a Night Mode extension):
