Error 404 Page Not Found#78
Merged
Merged
Conversation
zghera
approved these changes
Jul 20, 2020
anan-ya-y
approved these changes
Jul 21, 2020
Collaborator
Author
|
To keep consistent with PR #77, the ErrorNotFound directory was restructured as its own file in the Errors directory. The "Are there more details that are relevant?" section has been updated accordingly. |
HiramSilvey
approved these changes
Jul 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is a quick description of the change?
Creates an Error 404 Page Not Found page if the user attempts to visit a page that does not exist.
Is this fixing an issue?
none
Are there more details that are relevant?
The
ErrorPageNotFoundcomponent was added to theErrorsdirectory, and is imported into theAppcomponent.Check lists (check
xin[ ]of list items)Just renders a new page, no new logic was written.
Any additional comments?
GIF below (it is dark because I was using a Night Mode extension):
