refactor(cluster): Default item rendering to onBeforeClusterItemRendered()#633
Merged
barbeau merged 1 commit intogooglemaps:masterfrom Feb 21, 2020
CUTR-at-USF:refactor-default-cluster-item
Merged
refactor(cluster): Default item rendering to onBeforeClusterItemRendered()#633barbeau merged 1 commit intogooglemaps:masterfrom CUTR-at-USF:refactor-default-cluster-item
barbeau merged 1 commit intogooglemaps:masterfrom
CUTR-at-USF:refactor-default-cluster-item
Conversation
Codecov Report
@@ Coverage Diff @@
## master #633 +/- ##
=======================================
Coverage 19.00% 19.00%
=======================================
Files 71 71
Lines 4056 4056
Branches 610 609 -1
=======================================
Hits 771 771
Misses 3251 3251
Partials 34 34 Continue to review full report at Codecov.
|
Merged
arriolac
added a commit
that referenced
this pull request
Feb 25, 2020
arriolac
added a commit
that referenced
this pull request
Feb 25, 2020
* chore(Release): 1.0.0 * Adding 1.0.0 header and removing duplicate issue. * Remove dupe issues. * Add #633 to breaking changes list.
arriolac
added a commit
that referenced
this pull request
Feb 26, 2020
* chore(Release): 1.0.0 * Adding 1.0.0 header and removing duplicate issue. * Remove dupe issues. * Add #633 to breaking changes list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #630, refactor the default cluster item rendering implementation from a private method into the protected method
onBeforeClusterItemRendered(). This allows apps that extendDefaultClusterRendererto easily override the default behavior.I also made the following style changes to the rendering code to make it easier to read (but doesn't change function):
!(item.getTitle() == null)toitem.getTitle() != null.Refs: 630
Fixes #630