Skip to content

chore(Release): 1.0.0#635

Merged
arriolac merged 4 commits intomasterfrom
release/1.0.0
Feb 25, 2020
Merged

chore(Release): 1.0.0#635
arriolac merged 4 commits intomasterfrom
release/1.0.0

Conversation

@arriolac
Copy link
Contributor

@arriolac arriolac commented Feb 24, 2020

Will tag once merged.

@arriolac arriolac requested a review from barbeau February 24, 2020 21:34
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 24, 2020
barbeau
barbeau reviewed Feb 24, 2020
View reviewed changes
Copy link
Collaborator

@barbeau barbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

Generally LGTM, modulo the two in-line comments.

@codecov
Copy link

codecov bot commented Feb 24, 2020 •
edited
Loading

Codecov Report

Merging #635 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #635   +/-   ##
=======================================
  Coverage   18.99%   18.99%           
=======================================
  Files          71       71           
  Lines        4037     4037           
  Branches      606      606           
=======================================
  Hits          767      767           
  Misses       3238     3238           
  Partials       32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 731f7e6...9a5bd2a. Read the comment docs.

barbeau
barbeau reviewed Feb 24, 2020
View reviewed changes
@barbeau
Copy link
Collaborator

barbeau commented Feb 25, 2020

Also, #633 should technically be listed under "Breaking changes" because behavior changed.

@arriolac
Copy link
Contributor Author

arriolac commented Feb 25, 2020

Also, #633 should technically be listed under "Breaking changes" because behavior changed.

Good catch—will update. Looks like the tool I used leaves out refactor type commit messages in the auto-generated changelog. A commit message with "BREAKING CHANGE" (number 3 in https://www.conventionalcommits.org/en/v1.0.0/) will catch though (left up to the person merging which is easy to forget).

BREAKING CHANGE: a commit that has a footer BREAKING CHANGE:, or appends a ! after the type/scope, introduces a breaking API change (correlating with MAJOR in semantic versioning). A BREAKING CHANGE can be part of commits of any type.

@barbeau
Copy link
Collaborator

barbeau commented Feb 25, 2020

@arriolac Ah, you're right - my bad for not including that in the commit message 🤦‍♂️

@arriolac arriolac mentioned this pull request Feb 25, 2020
Merged
@arriolac arriolac merged commit 26ee885 into master Feb 25, 2020
arriolac added a commit that referenced this pull request Feb 26, 2020
@arriolac
chore(Release): 1.0.0 (#635)
8296745 
* chore(Release): 1.0.0

* Adding 1.0.0 header and removing duplicate issue.

* Remove dupe issues.

* Add #633 to breaking changes list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barbeau barbeau barbeau left review comments

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arriolac @barbeau @googlebot