Skip to content

fix: Telephone validation in sell goods or services form#53

Merged
Ethical-Ralph merged 1 commit intodevelopfrom
fix/telephone-validations
Jan 16, 2026
Merged

fix: Telephone validation in sell goods or services form#53
Ethical-Ralph merged 1 commit intodevelopfrom
fix/telephone-validations

Conversation

@sajclarke
Copy link
Contributor

Description

This PR fixes telephone number validation in the "Sell Goods or Services on Beach/Park" form. The validation regex has been removed to allow more flexible telephone number formats while maintaining the required field constraint.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Changes Made

  • Remove overly restrictive telephone number validation regex from the sell goods or services form
  • Keep the telephone number field as required while allowing broader input formats

Files Changed

  • schemas/sell-goods-services-beach-park.json - Removed regex validation pattern for telephone number field (5 lines removed, 1 line added)

Notes

The previous validation regex (^\\+?[0-9]{10,15}$) was too restrictive. This change simplifies validation while keeping the field required, allowing the backend or alternative validation methods to handle more flexible telephone number formats.

Testing

  • Form submission tested with various telephone number formats
  • Verify telephone field is still required
  • Test form rendering with updated schema
  • Validate backend handles telephone numbers correctly
  • Test on all supported device sizes

Related Github Issue(s)/Trello Ticket(s)

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Tests added/updated
  • Documentation updated

@amazon-inspector-n-virginia
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@amazon-inspector-n-virginia
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@Ethical-Ralph Ethical-Ralph merged commit ff49d14 into develop Jan 16, 2026
2 checks passed
Ethical-Ralph added a commit that referenced this pull request Jan 16, 2026
* Updated missing validation

* Fix (forms): update schema for "redirect business mail" api (#55)

* fix: update schema to match figma

* fix: update form schema and validations for empty strings

* fix: telephone validation in sell goods or services form (#53)

* fix (forms): change api for "Tell Post Office someone died" form (#54)

* fix: update schema for deceased form to match figma

* fix: gracefully fail if unable to connect to smtp server

* chore: update email error logic

---------

Co-authored-by: IsaiahSama <isaiahcarrington46@gmail.com>
Co-authored-by: Akinola Raphael <rakinola90@gmail.com>
@sajclarke sajclarke mentioned this pull request Jan 16, 2026
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants