fix: Telephone validation in sell goods or services form#53
Merged
Ethical-Ralph merged 1 commit intodevelopfrom Jan 16, 2026
Merged
fix: Telephone validation in sell goods or services form#53Ethical-Ralph merged 1 commit intodevelopfrom
Ethical-Ralph merged 1 commit intodevelopfrom
Conversation
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
Ethical-Ralph
approved these changes
Jan 16, 2026
Ethical-Ralph
added a commit
that referenced
this pull request
Jan 16, 2026
* Updated missing validation * Fix (forms): update schema for "redirect business mail" api (#55) * fix: update schema to match figma * fix: update form schema and validations for empty strings * fix: telephone validation in sell goods or services form (#53) * fix (forms): change api for "Tell Post Office someone died" form (#54) * fix: update schema for deceased form to match figma * fix: gracefully fail if unable to connect to smtp server * chore: update email error logic --------- Co-authored-by: IsaiahSama <isaiahcarrington46@gmail.com> Co-authored-by: Akinola Raphael <rakinola90@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes telephone number validation in the "Sell Goods or Services on Beach/Park" form. The validation regex has been removed to allow more flexible telephone number formats while maintaining the required field constraint.
Type of Change
Changes Made
Files Changed
Notes
The previous validation regex (
^\\+?[0-9]{10,15}$) was too restrictive. This change simplifies validation while keeping the field required, allowing the backend or alternative validation methods to handle more flexible telephone number formats.Testing
Related Github Issue(s)/Trello Ticket(s)
Checklist