RELEASE

[sajclarke]

Description

This PR introduces multiple form improvements and fixes across the form processor API, including schema updates for business and deceased post-office redirection forms, enhancements to the sell goods/services form, improved email error handling, and comprehensive string validation improvements.

Type of Change

• Bug fix
• New feature
• Breaking change
• Documentation update

Changes Made

Post-Office Redirection - Deceased Form

• Rename "applicant" section to "deceased" for clarity
• Add middle name field to deceased person's information
• Change "dateOfBirth" to "dateOfDeath"
• Remove email and telephone fields from deceased section
• Remove ID number and passport number fields
• Update label capitalization

Post-Office Redirection - Business Form

• Restructure schema to prioritize business name at top level
• Rename "oldBusinessAddress" to "currentAddress"
• Add postcode field with Barbados postal code validation (BB##### format)
• Update field labels and organization
• Reorganize applicant information section

Sell Goods/Services on Beach/Park Form

• Add nationality field (required)
• Remove telephone number regex validation
• Remove minimum length validation from ID number field

Email Service & Processing

• Improve email error handling to gracefully fail when SMTP connection unavailable
• Update email template for post-office redirection notices
• Refactor email processor logic

Validation Service

• Enhanced string validation to reject empty strings for required fields
• Refactor schema-builder service to properly handle required vs optional strings
• Add explicit validation for minimum length of 1 character for required fields
• Consolidate validation logic for consistency

Files Changed

• schemas/post-office-redirection-business.json - Form restructuring (166 changes)
• schemas/post-office-redirection-deceased.json - Form updates (152 changes)
• schemas/sell-goods-services-beach-park.json - Schema enhancements (13 changes)
• src/email/email.service.ts - Error handling improvements (6 changes)
• src/email/templates/post-office-redirection-notice.hbs - Template updates (210 changes)
• src/processors/implementations/email.processor.ts - Processor refactoring (41 changes)
• src/validation/schema-builder.service.ts - Validation logic improvements (35 changes)

Notes

These changes align multiple forms with updated Figma designs, improve form data validation to prevent empty submissions, and enhance system resilience by gracefully handling email failures. The nationality field addition and validation improvements strengthen data quality, while the postal code validation ensures Barbados-specific address formatting.

Testing

• All form validations tested with empty/whitespace inputs
• Verify required fields reject invalid submissions
• Test optional fields accept empty values appropriately
• Form rendering validated with new schema structures
• Postcode validation tested (BB##### format)
• Email service tested with SMTP connection failures
• All forms submitted end-to-end
• Responsive design verified across device sizes
• Backward compatibility checked for existing submissions

Related Github Issue(s)/Trello Ticket(s)

• Related PRs: fix (forms): Added missing schema validations for Sell Goods and Services on Beach #52, fix: Telephone validation in sell goods or services form #53, fix (forms): change api for "Tell Post Office someone died" form #54, Fix (forms): update schema for "redirect business mail" api #55

Checklist

• Code follows project style guidelines
• Self-review completed
• Tests added/updated for all validation changes
• Documentation updated
• Email template changes reviewed
• All schema changes verified against Figma designs