Skip to content

Quickfix (Sell Goods): Fixed issue where min was making an optional field required#88

Merged
Ethical-Ralph merged 1 commit intodevelopfrom
quickfix/sell-goods-validation-update
Jan 30, 2026
Merged

Quickfix (Sell Goods): Fixed issue where min was making an optional field required#88
Ethical-Ralph merged 1 commit intodevelopfrom
quickfix/sell-goods-validation-update

Conversation

@IsaiahSama
Copy link
Contributor

Description

Fixed issue where min validation was forcing Manufacturing Location to be seen as required although it isn'tt.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Changes Made

  • schemas/sell-goods-services-beach-park.json

Notes

Testing

  • Manual tests completed
  • Added unit tests
  • Added e2e tests

Related Github Issue(s)/Trello Ticket(s)

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Documentation updated

@amazon-inspector-n-virginia
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@amazon-inspector-n-virginia
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

Copy link
Contributor

@phrogwrld phrogwrld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ethical-Ralph Ethical-Ralph merged commit f75527e into develop Jan 30, 2026
2 checks passed
@Ethical-Ralph Ethical-Ralph deleted the quickfix/sell-goods-validation-update branch January 30, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants