Merged
Conversation
* feat: implement conditional required and validation logic for form fields * feat: enhance validation logic for father and mother fields in birth registration form * feat: implement dynamic validation messages and health facility constants for OpenCRVS integration * feat: change age field type to string and update validation logic for age range in register birth form * feat: remove localhost URL handling from OpenCRVS service configuration --------- Co-authored-by: Akinola Raphael <54055273+Ethical-Ralph@users.noreply.github.com>
chore: add testimonial fields to sell goods/services schema
* fix: adjust token expiration time from 1 hour to 10 minutes * feat(opencrvs): integrate jwt-decode to dynamically set expiration time with a fallback of 10 minutes. * refactor: imporve the calculation to expiry time
…mail Chore (Forms): Updated receipt email template for Personal Mail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR merges improvements from the
developbranch intoproduction, including a new conditional validation system for form schemas, OpenCRVS token management improvements, email template enhancements, and schema updates for birth registration and sell goods forms.Type of Change
Changes Made
Core Validation Updates
required.whenwithall/anylogic to conditionally require fields based on other field valuesvalidations.conditionwiththen/elsebranches for dynamic validation rulesexists,missing,null,empty,notEmpty,equals,notEquals,in,notInFiles Changed
New Files
src/opencrvs/common/opencrvs.constants.tssrc/opencrvs/common/opencrvs.utils.tsModified Schema Files
schemas/register-birth-form.jsonschemas/sell-goods-services-beach-park.jsonfirstTestimonialandsecondTestimonialobjects with name, relationship, address, and testimonial fieldsModified OpenCRVS Files
src/opencrvs/opencrvs.service.tsjwt-decodeto calculate token expiry from JWT payload; removed localhost config optionsrc/opencrvs/opencrvs-cache.service.tssrc/opencrvs/opencrvs.processor.tssrc/opencrvs/types/opencrvs.types.tsHealthFacilitytype exportModified Email Templates
src/email/templates/post-office-redirection-individual-receipt.hbssrc/email/templates/sell-goods-services-beach-park-receipt.hbsModified Core Service Files
src/forms/forms.service.tssrc/forms/interfaces/form-schema.interface.tsConditionalRequired,ConditionalWhen,ConditionalRuleinterfaces; addedconditiontoFieldValidationsrc/validation/schema-builder.service.tssuperRefinefor conditional required and conditional validation evaluationsrc/processors/implementations/email.processor.tsInfrastructure/Config
src/config/configuration.tslocalhostoption for OpenCRVS configurationpackage.jsonjwt-decode^4.0.0 dependencypackage-lock.jsonNotes
expires_infor more accurate token refreshTesting
all/anylogicthen/else) apply correctlyRelated Github Issue(s)/Trello Ticket(s)
minwas making an optional field required #88: Quickfix (Sell Goods): Fixed issue whereminwas making an optional field requiredChecklist