Prevent auto finishing a coordinator if the download is dismissing#22
Merged
Prevent auto finishing a coordinator if the download is dismissing#22
Conversation
mediabounds
reviewed
Jul 20, 2022
Member
mediabounds
left a comment
mediabounds
left a comment
There was a problem hiding this comment.
Pending the changes in Float.Core, these changes seem reasonable to me.
mediabounds
previously requested changes
Jul 22, 2022
| startLocation = Activity.MetaData.StartLocation; | ||
| isCreatingRunner = true; | ||
|
|
||
| await NavigationContext.DismissPageAsync(); |
Member
There was a problem hiding this comment.
Before merging, since this will require a newer version of Float.Core, the csproj file needs to be updated to document the minimum version of Float.Core needed here.
Allow a popup page as the download page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.