Skip to content

Compat fix image copy #3150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
greggman merged 5 commits into from
Nov 10, 2023
Merged

Compat fix image copy #3150

greggman merged 5 commits into from
Nov 10, 2023

Conversation

@greggman
Copy link
Contributor

@greggman greggman commented Nov 9, 2023

Use comapt compatible pipelines for checking results.

Kai suggested not changing anything in core so it only uses the compat versions in compat mode.

Issue: #3143

Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@greggman greggman requested a review from kainino0x November 9, 2023 08:42
@greggman greggman force-pushed the compat-fix-image-copy branch from f1bc567 to 0a0768a Compare November 10, 2023 01:24
kainino0x
kainino0x approved these changes Nov 10, 2023
View reviewed changes
@greggman greggman enabled auto-merge (rebase) November 10, 2023 05:17
greggman and others added 5 commits November 9, 2023 21:23
@greggman
Revert "Skip compressed image_copy tests in Compatibility mode. (gpuw…
332f1c7 
…eb#3140)"

This reverts commit 2835c6b.
@greggman
Compat: make expectTexturesToMatchByRendering work with compat
f4b2e57 
With the new textureBindingViewDimension requirements
this pipeline has to use texture_2d_array for 2d_array textures.
@greggman @kainino0x
Update src/webgpu/gpu_test.ts
bd2784f 
Co-authored-by: Kai Ninomiya <kainino1@gmail.com>
@greggman @kainino0x
Update src/webgpu/gpu_test.ts
7d15b9f 
Co-authored-by: Kai Ninomiya <kainino1@gmail.com>
@greggman
address review comments
e4ddc30
@greggman greggman force-pushed the compat-fix-image-copy branch from 8c2d489 to e4ddc30 Compare November 10, 2023 05:23
@greggman greggman merged commit 8eee61b into gpuweb:main Nov 10, 2023
@greggman greggman deleted the compat-fix-image-copy branch November 10, 2023 05:57
@greggman greggman mentioned this pull request Nov 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kainino0x kainino0x kainino0x approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@greggman @kainino0x