-
Notifications
You must be signed in to change notification settings - Fork 101
Fix texture-component-swizzle typo #4498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix texture-component-swizzle typo #4498
Conversation
1b893d6 to
4d68eae
Compare
|
This turned into a bigger change than just fixing the typo. This comes up with depth textures because if texture-component-swizzle Theoretically, with this change, the software sampler code supports It seems to be passing now. The failure there seem related to #4495 |
src/webgpu/api/validation/capability_checks/features/texture_component_swizzle_utils.ts
Show resolved
Hide resolved
src/webgpu/shader/execution/expression/call/builtin/texture_utils.ts
Outdated
Show resolved
Hide resolved
src/webgpu/shader/execution/expression/call/builtin/texture_utils.ts
Outdated
Show resolved
Hide resolved
03201f4 to
10022b1
Compare
This turned into a bigger change than just fixing the typo. With the typo fixed, a bunch of tests started failing. One issue in particular is that out of bounds `textureLoad` needs to take swizzle into account since its allowed to return any value inside the texture. I'm making the assuption that the spec would say it can return any swizzled value in the texture. This comes up with depth textures because if texture-component-swizzle is enabled then we check RGBA for depth textures instead of just R and we expcet GBA to be 001. Before this change, if the texel address was invalid we'd get a texel from the software texture and GBA would be wrong and so no texels would match. Theoretically, with this change, the software sampler code supports swizzles but, that path is not really be exercised. Only the fact that depth textures go from R??? to R001 is used.
10022b1 to
e857101
Compare
Chromium CQ test here