Skip to content

Conversation

@greggman
Copy link
Contributor

The problem with features.has is that it takes a string isntead of a GPUFeatureName. To prevent typos when checking for features, add a lint warning for features.has(feature) and suggest using hasFeature(features, feature). hasFeature takes a GPUFeatureName and so will warn if the string pass is not a valid feature.

With this change this issue would have been caught before submission.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

The problem with `features.has` is that it takes
a string isntead of a `GPUFeatureName`. To prevent
typos when checking for features, add a lint warning
for `features.has(feature)` and suggest using
`hasFeature(features, feature)`. `hasFeature`
takes a `GPUFeatureName` and so will warn if the
string pass is not a valid feature.
Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice lint rule, LGTM!

@greggman greggman merged commit 3314e41 into gpuweb:main Nov 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants