Add appImageOptions to JPackage tasks#61
Conversation
|
Not working Working on a fix |
|
Fix: Add new option |
appImageOptions to JPackage tasks
|
I merged JabRef/jabref#13401 to keep things going. If we change this logic here, we need to adapt the main JabRef build, too. OK, we need to do in call cases as the local build will stop running for all who have not checked out |
|
Thank you @koppor. Yet another missing feature. It makes sense to add this. Merging this into the I'll work on adding some tests for all the new features asap to validate that everything is sound and then do a release. |
|
Thank you 😅 (NNTR, just persisting thoughts) I was thinking whether I should propose more strong typing. Having dedicated variables for |
--win-consolewas not functioning in thepreviewbranchoptions.addAll("--win-console")This PR fixes it.
I think, options should be passed in all
app-imagecases, therefore, I left then in there - but also copied them intoconfigureJPackageArguments