Skip to content

Add appImageOptions to JPackage tasks #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjohannes merged 4 commits into from
Jul 2, 2025
Merged

Add appImageOptions to JPackage tasks #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
debb75b
Add options in app-image case
koppor Jun 30, 2025
0f660e5
Revert "Add options in app-image case"
koppor Jun 30, 2025
c973ac2
Remove unused import
koppor Jun 30, 2025
a9efaee
Add appImageOptions just for type app-image
koppor Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/gradlex/javamodule/packaging/JavaModulePackagingExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
import org.gradle.api.NamedDomainObjectSet;
import org.gradle.api.NonNullApi;
import org.gradle.api.Project;
import org.gradle.api.Task;
import org.gradle.api.artifacts.Configuration;
import org.gradle.api.artifacts.ConfigurationContainer;
import org.gradle.api.attributes.Attribute;
Expand Down Expand Up @@ -257,6 +256,7 @@ private void registerTargetSpecificTasks(Target target, String applicationJarTas
t.getJlinkOptions().convention(getJlinkOptions());
t.getAddModules().convention(getAddModules());
t.getOptions().convention(target.getOptions());
t.getAppImageOptions().convention(target.getAppImageOptions());
t.getPackageTypes().convention(target.getPackageTypes());
t.getSingleStepPackaging().convention(target.getSingleStepPackaging());
t.getResources().from(getResources());
Expand Down
1 change: 1 addition & 0 deletions src/main/java/org/gradlex/javamodule/packaging/model/Target.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ abstract public class Target {

abstract public ListProperty<String> getPackageTypes();
abstract public ListProperty<String> getOptions();
abstract public ListProperty<String> getAppImageOptions();

abstract public ConfigurableFileCollection getTargetResources();

Expand Down
6 changes: 6 additions & 0 deletions src/main/java/org/gradlex/javamodule/packaging/tasks/Jpackage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,9 @@ abstract public class Jpackage extends DefaultTask {
@Input
abstract public ListProperty<String> getOptions();

@Input
abstract public ListProperty<String> getAppImageOptions();

@Input
abstract public ListProperty<String> getPackageTypes();

Expand Down Expand Up @@ -238,6 +241,9 @@ private void performAppImageStep(String jpackage, Directory resourcesDir) {
getDestination().get().getAsFile().getPath()
);
configureJPackageArguments(e, resourcesDir);
for (String option : getAppImageOptions().get()) {
e.args(option);
}
});
}

Expand Down