Skip to content
This repository was archived by the owner on Jan 8, 2025. It is now read-only.

Revert "Second version of mdx-to-hast transformer"#241

Merged
hatched merged 5 commits intomainfrom
revert-225-iadramelk/mdx-rehype-v2
Mar 7, 2023
Merged

Revert "Second version of mdx-to-hast transformer"#241
hatched merged 5 commits intomainfrom
revert-225-iadramelk/mdx-rehype-v2

Conversation

@alexfornuto
Copy link
Contributor

@alexfornuto alexfornuto commented Feb 28, 2023

Reverts #225 because only after merging did I notice a bug: in the partial file docs/pages/includes/tctl.mdx (and maybe others), the cloud version of the Details block is always visible:

https://www.loom.com/share/6ba8bdeb2025454396b66b5075bc3b66

@vercel
Copy link

vercel bot commented Feb 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
docs ✅ Ready (Inspect) Visit Preview Mar 7, 2023 at 9:52PM (UTC)

ptgott
ptgott previously approved these changes Feb 28, 2023
Copy link
Contributor

@hatched hatched left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of reverting all of these changes I've created a PR that appears to fix the root issue: #242

@hatched hatched closed this Feb 28, 2023
@alexfornuto alexfornuto reopened this Mar 6, 2023
@alexfornuto
Copy link
Contributor Author

Re-opened to be re-evaluated, as several other bugs have been discovered and traced back to this change.

hatched
hatched previously approved these changes Mar 6, 2023
…erability check

   yarn.lock » dns-packet@5.3.1 – Potential memory exposure in dns-packet (high severity)
    ↪ GHSA-3wcq-x3mq-6r9p
  yarn.lock » json5@2.2.1 – Prototype Pollution in JSON5 via Parse Method (high severity)
    ↪ GHSA-9c47-m6qq-7p4h
@hatched hatched merged commit 04f39e8 into main Mar 7, 2023
iAdramelk added a commit that referenced this pull request Mar 15, 2023
iAdramelk added a commit that referenced this pull request Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants