Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Hey Evan, Can you add a bit of context on the changes you've made to the codebase and why they've been made? I know that we have the issue markes, and that you've referenced them within this PR, but it's good practice to put a summary together so that whoever is reviewing it has an easier time following along with the changes you've submitted. |
|
@spiteless I used a slightly different approach to address your comments. I tested it and it works still. |
|
Hey @evanyang1 , looks like merging is blocked becasue I requested changes and haven't come back yet to remove that change request. My bad. Combing back through the PR I see that you addressed getting the form submission issue that was cropping up. Looks like edits to |
|
Ok that should do the trick. |
236d024 to
7074341
Compare
7074341 to
28fdb34
Compare
|
Great job, thanks for rebasing and dropping yarn lock. We've got a few PRs that all tackle this similar issue so stitching them together will be it's own beast, but this code works. Thanks @evanyang1 ! |
|
Looking for a few more eyes on this if someone else has time. I'm happy with it's current state |
MattPereira
left a comment
There was a problem hiding this comment.
@evanyang1 well done sanitizing the meeting name input according to the requirements of the issue!

Fixes #1403
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Details