Event Name Validation: blacklisted strings#1805
Merged
trillium merged 5 commits intohackforla:developmentfrom May 7, 2025
Merged
Event Name Validation: blacklisted strings#1805trillium merged 5 commits intohackforla:developmentfrom
trillium merged 5 commits intohackforla:developmentfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
nora-zajzon
approved these changes
Oct 27, 2024
Member
nora-zajzon
left a comment
There was a problem hiding this comment.
Works great! All the names/strings specified in the issue are not useable regardless of capitalization.
Member
|
@trillium to review |
trillium
approved these changes
May 7, 2025
Member
trillium
left a comment
There was a problem hiding this comment.
This looks good, thanks for the changes Pluto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1514
What changes did you make and why did you make them ?
Added a new file,
client/src/utils/blacklist.js, to hold array of strings that cannot be used in event names. I made the file name general so that future blacklists can be added here.utilsor not, so let me know if I should place it elsewhere.I imported the array into
client/src/components/manageProjects/utilities/validateEventForm.jsand implemented it into the framework used by Evn validation 1403 #1440Event name cannot contain 'meeting' or 'mtg' or the project name,Screen Captures of Proposed Changes
Screen Capture before changes are applied
before-new-validation-vrms.mov
Screen Capture after changes are applied
event-name-validation-vrms.mov