-
-
Notifications
You must be signed in to change notification settings - Fork 847
Closed
Labels
Complexity: LargeFeature: Refactor HTMLFeature: Refactor JS / LiquidPage is working fine - JS / Liquid needs changes to become consistent with other pagesPage is working fine - JS / Liquid needs changes to become consistent with other pagesp-feature: Projects-checkWe use this page to check to make sure that teams are using the Technology section correctlyWe use this page to check to make sure that teams are using the Technology section correctlyrole: front endTasks for front end developersTasks for front end developerssize: 2ptCan be done in 7-12 hoursCan be done in 7-12 hours
Milestone
Description
Dependencies
- Create new issues to refactor Tools data in project md files #4777
- Add a Tools filter to the projects check page #4427
Overview
We need to refactor the HTML and JavaScript for the Projects and Projects-Check pages, so that both pages share the same HTML and JavaScript files. The differences in filter options between the two pages will be implemented by adding conditional logic in JavaScript based on the current page URL.
Details
- The difference between the Projects page and the Projects-Check pages is that the Projects-Check page has only the Technologies, Languages, and Tools filter options, in order to enable testing.
- As time has passed and the Projects page has been developed, the JavaScript code in particular has diverged between the Projects and Projects-Check pages and some unintended differences have been observed in the Projects page.
Action Items
- In the IDE, modify
_pages/projects-check.htmlso that it includescurrent-projects.htmlinstead ofcurrent-projects-check.html. As a result of this change, the projects-check page will reference the same HTML include and same JavaScript as the projects page. - Examine the differences in JavaScript between
/assets/js/current-projects-check.jsand/assets/js/current-projects.js. For each difference, determine if the difference is required to implement the distinct filter options required on the Projects-Check page.- If the difference is required, add conditional logic in the JavaScript to implement the desired behavior in the Projects Check page
- If the difference is not required, do nothing
- Confirm that the appearance and behavior of the projects-check page matches that of the projects page except for the filter selection
- Confirm that if more than 8 categories exist in a filter section, only 8 are displayed but a "View All" link is displayed.
- Confirm that as filters are applied, filter tags appear under the heading "Applied FIlters" and clicking the tags clears the filters.
- Confirm that if more than 8 categores exist in both the Technology and Language (and Tools?) groups, it should be possible to view all the filters in both groups at once.
Resources/Instructions
- For a discussion of the intentional differences between projects-check and project pages, see Create a copy of the project page with only two filters: technology and language #2502
- Projects page: webpage | HTML include | JavaScript
- Projects Check page: webpage | HTML include | JavaScript
- This issue is a result of ER: filter on projects-check page differs from filter on projects page #4834
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Complexity: LargeFeature: Refactor HTMLFeature: Refactor JS / LiquidPage is working fine - JS / Liquid needs changes to become consistent with other pagesPage is working fine - JS / Liquid needs changes to become consistent with other pagesp-feature: Projects-checkWe use this page to check to make sure that teams are using the Technology section correctlyWe use this page to check to make sure that teams are using the Technology section correctlyrole: front endTasks for front end developersTasks for front end developerssize: 2ptCan be done in 7-12 hoursCan be done in 7-12 hours
Type
Projects
Status
Done