-
-
Notifications
You must be signed in to change notification settings - Fork 847
Description
Dependencies (Child Issues)
- replace
GithubwithGitHubin website/redirections/github.md #7110 - replace
GithubwithGitHubin communities-of-practice.html #7111 - Replace
GithubwithGitHubin _data/navigation/social.yml #7112 - Replace
GithubwithGitHubin _data/internal/communities/ui-ux.yml #7113 - Replace
GithubwithGitHubin _data/internal/communities/engineering.yml #7115 - Replace
GithubwithGitHubin _data/internal/communities/project-management.yml #7117 - Replace
GithubwithGitHubin pages/getting-started.html #7118 - Replace
GithubwithGitHubin _projects/ems-triage-tracker.md #7413 - Replace
GithubwithGitHubin _projects/tech-work-experience.md #7414 - Replace
GithubwithGitHubin _data/internal/communities/ops.yml #7415 - Replace
GithubwithGitHubin _data/internal/communities/data-science.yml #7416 - Replace
githubwithGitHubin github-actions/utils/post-issue-comment.js #7417 - Replace
GithubwithGitHubin _guide-pages/2FA.html #7418 - Replace
GithubwithGitHubin _sass/components/_guides.scss #7419 - Replace
githubwithGitHubin _sass/components/_communities-of-practice.scss #7420 - Replace
GithubwithGitHubin github-actions/trigger-issue/add-missing-labels-to-issues/add-labels-template.md #7421 - Replace
GithubwithGitHubin assets/js/utility/api-events.js #7422 - Replace
GithubwithGitHubin github-actions/trigger-schedule/list-inactive-members/get-contributors-data.js #7423 - Replace
GithubwithGitHubin CONTRIBUTING.md Table of Contents 1.4.c #7438 - Replace
GithubwithGitHubin CONTRIBUTING.md Section 1.4 #7439 - Replace
githubwithGitHubin CONTRIBUTING.md Section 2.7.e #7440 - Replace
githubwithGitHubin CONTRIBUTING.md Section 2.7.f i #7441 - Replace
githubwithGitHubin CONTRIBUTING.md Section 2.7.f ii #7442 - Replace
GithubwithGitHubin CONTRIBUTING.md Section 4.2.b #7443 - Replace
GithubwithGitHubin assets/js/wins.jsmakecards#7494 - Replace
GithubwithGitHubin assets/js/wins.jsupdateOverlay#7495 - Replace
GithubwithGitHubin _data/internal/toolkitresources.yml #8390 - Replace
GithubwithGitHubin feature-homepage-launch/_data/navigation/social.yml #8508 - To do: Issues for Code.js and wins.js, which are linked to the Wins Form
Emergent Requirement - Problem
GitHub is a company name and should only be in lowercase (github) when in a URL, variable or directory name (where the variables or directories are all lowercase).
Details
There are 180 files with some form of github in it.
Issue you discovered this emergent requirement in
Date discovered
2024-01-25
Did you have to do something temporarily
- YES
- NO
Who was involved
What happens if this is not addressed
- If it's public facing, it's unprofessional not to fix it.
- if it's in our non-public facing code, it's best practices to use it consistently as intended
Resources
- 180 files in our repo with some form of the name github in it
- I reviewed all the instances, and divided them up into could, be careful, and must.
Examples of locations that could be changed
* @returns {String} - returns a formatted comment to be posted on github * Posts a comment on github // Since Github only allows to fetch max 100 items per request, we need to 'flip' pages website/pages/wins/wins-share-form.html
Line 464 in 3c7c90e
//github photo permission website/_sass/components/_guides.scss
Line 249 in 3c7c90e
/* Populates an empty div for Users with no Github Link */ website/assets/js/utility/api-events.js
Line 36 in 3c7c90e
// If a project doesn't have an hflaWebsiteUrl, redirect to the project's Github page
Example of locations that could be changed, but it might break some logic.
website/redirections/github.md
Line 4 in 3c7c90e
title: Github title="{{community[1].name}} Github Repo"> website/_data/navigation/social.yml
Line 31 in 3c7c90e
- name: Github - name: Github - name: Github - name: Github - title: Github
Examples of locations it must be changed
website/_guide-pages/github-issues.html
Line 35 in 3c7c90e
<h5>An effective Hack for LA Github issue includes the following components:</h5> website/pages/getting-started.html
Line 101 in 3c7c90e
<li class="g-s-list">Receive access to the Google Drive and Github repository by sending a Slack message of your Github username and Gmail address to a CoP lead. <img class="info-icon" src="assets/images/getting-started/information.png" alt="">
Recommended Action Items
- Make 2 issue templates in comments that will work for all the following types of changes, so that each issue is easy to make
- Review each potential change and decide if It's something that can be changed
- without risk, in which case it's a good first issue
- Examples of locations that could be changed
- Examples of locations it must be changed
- might have risk and will need to be tested, in case it's a medium issue and will need to specify that the assignee will have to devise and document what tests they intend to do, so that when the PR is reviewed, the merge team can sign off that the change was tested adequately.
- Example of locations that could be changed, but it might break some logic.
- without risk, in which case it's a good first issue
- move this issue to the questions column and add the
ready for merge teamlabel with the following note in a comment - make issues - see Dependencies section above
Potential solutions [draft]
Sub-issues
Metadata
Metadata
Assignees
Labels
Type
Projects
Status